Bug 77243

Summary: [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 77287    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Nico Weber
Reported 2012-01-27 14:12:45 PST
[chromium] Add support for building standalone webkit/chromium checkouts with ninja.
Attachments
Patch (4.73 KB, patch)
2012-01-27 14:13 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (6.42 KB, patch)
2012-01-27 17:51 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (6.42 KB, patch)
2012-01-27 18:10 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2012-01-27 14:13:03 PST
Created attachment 124367 [details] Patch
Nico Weber
Comment 2 2012-01-27 14:14:16 PST
Comment on attachment 124367 [details] Patch This will probably do it, but it looks like nobody ever used ninja/linux with standalone webkit builds yet -- the ninja gyp generator can't handle this configuration yet. I'm looking into that.
Nico Weber
Comment 3 2012-01-27 17:51:50 PST
Created attachment 124410 [details] Patch
Nico Weber
Comment 4 2012-01-27 17:52:13 PST
Depends on http://codereview.chromium.org/9298039/
Nico Weber
Comment 5 2012-01-27 18:10:38 PST
Created attachment 124413 [details] Patch
Adam Barth
Comment 6 2012-01-28 00:14:24 PST
Thanks! Please feel free to land whenever everything else is in place.
Nico Weber
Comment 7 2012-01-28 14:21:22 PST
Landing should be safe now (modulo possible breakages I might have introduced), but it needs the chromium deps roll in bug 77287 to actually work. Once that's in Tools/Scripts/update-webkit --chromium --ninja Tools/Scripts/build-webkit --chromium should do the trick. I only ran that a single time and verified that the build doesn't fail, and didn't do any testing. Let me know how it goes!
WebKit Review Bot
Comment 8 2012-01-28 15:43:47 PST
Comment on attachment 124413 [details] Patch Clearing flags on attachment: 124413 Committed r106195: <http://trac.webkit.org/changeset/106195>
WebKit Review Bot
Comment 9 2012-01-28 15:43:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.