Summary: | [chromium] Add support for building standalone webkit/chromium checkouts with ninja. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nico Weber <thakis> | ||||||||
Component: | New Bugs | Assignee: | Nico Weber <thakis> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, jochen, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 77287 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Nico Weber
2012-01-27 14:12:45 PST
Created attachment 124367 [details]
Patch
Comment on attachment 124367 [details]
Patch
This will probably do it, but it looks like nobody ever used ninja/linux with standalone webkit builds yet -- the ninja gyp generator can't handle this configuration yet. I'm looking into that.
Created attachment 124410 [details]
Patch
Depends on http://codereview.chromium.org/9298039/ Created attachment 124413 [details]
Patch
Thanks! Please feel free to land whenever everything else is in place. Landing should be safe now (modulo possible breakages I might have introduced), but it needs the chromium deps roll in bug 77287 to actually work. Once that's in Tools/Scripts/update-webkit --chromium --ninja Tools/Scripts/build-webkit --chromium should do the trick. I only ran that a single time and verified that the build doesn't fail, and didn't do any testing. Let me know how it goes! Comment on attachment 124413 [details] Patch Clearing flags on attachment: 124413 Committed r106195: <http://trac.webkit.org/changeset/106195> All reviewed patches have been landed. Closing bug. |