| Summary: | The cpp parser of prepare-ChangeLog treats if(...) {} as a method | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||||||
| Component: | Tools / Tests | Assignee: | Kentaro Hara <haraken> | ||||||||||
| Status: | NEW --- | ||||||||||||
| Severity: | Normal | CC: | ddkilzer, rniwa, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 124362 [details]
Patch
Comment on attachment 124362 [details] Patch Rejecting attachment 124362 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: epare-ChangeLog patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp Hunk #1 FAILED at 303. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1 Full output: http://queues.webkit.org/results/11191949 Created attachment 124426 [details]
rebased patch for commit
Comment on attachment 124426 [details] rebased patch for commit Rejecting attachment 124426 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: patching file Tools/Scripts/prepare-ChangeLog patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp Hunk #1 FAILED at 303. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/11358409 Comment on attachment 124426 [details] rebased patch for commit Rejecting attachment 124426 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: patching file Tools/Scripts/prepare-ChangeLog patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp Hunk #1 FAILED at 303. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/11191975 Created attachment 124427 [details]
rebased patch for commit
Created attachment 124428 [details]
rebased patch for commit
Comment on attachment 124428 [details] rebased patch for commit Clearing flags on attachment: 124428 Committed r106183: <http://trac.webkit.org/changeset/106183> |
The cpp parser of prepare-ChangeLog is wrong, and an inner {} block in a method is treated as a method. Accurately, an inner {} block in a method in some namespace or class is treated as a method. class C { void func() { if (1) { // This is treated as a method. } } };