Bug 77241

Summary:

The cpp parser of prepare-ChangeLog treats if(...) {} as a method

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

Tools / Tests

Assignee:

Kentaro Hara <haraken>

Status:

NEW

Severity:

Normal

CC:

ddkilzer, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-
rebased patch for commit	webkit.review.bot: commit-queue-
rebased patch for commit	none
rebased patch for commit	none

Kentaro Hara

Reported 2012-01-27 13:49:56 PST

The cpp parser of prepare-ChangeLog is wrong, and an inner {} block in a method is treated as a method. Accurately, an inner {} block in a method in some namespace or class is treated as a method. class C { void func() { if (1) { // This is treated as a method. } } };

Attachments
Patch (5.16 KB, patch) 2012-01-27 13:55 PST, Kentaro Hara	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
rebased patch for commit (5.16 KB, patch) 2012-01-27 20:52 PST, Kentaro Hara	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
rebased patch for commit (5.38 KB, patch) 2012-01-27 21:06 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
rebased patch for commit (5.13 KB, patch) 2012-01-27 21:17 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-01-27 13:55:44 PST

Created attachment 124362 [details] Patch

WebKit Review Bot

Comment 2 2012-01-27 19:11:31 PST

Comment on attachment 124362 [details] Patch Rejecting attachment 124362 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: epare-ChangeLog patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp Hunk #1 FAILED at 303. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1 Full output: http://queues.webkit.org/results/11191949

Kentaro Hara

Comment 3 2012-01-27 20:52:05 PST

Created attachment 124426 [details] rebased patch for commit

WebKit Review Bot

Comment 4 2012-01-27 20:55:51 PST

Comment on attachment 124426 [details] rebased patch for commit Rejecting attachment 124426 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: patching file Tools/Scripts/prepare-ChangeLog patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp Hunk #1 FAILED at 303. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/11358409

WebKit Review Bot

Comment 5 2012-01-27 21:02:45 PST

Kentaro Hara

Comment 6 2012-01-27 21:06:36 PST

Created attachment 124427 [details] rebased patch for commit

Kentaro Hara

Comment 7 2012-01-27 21:17:28 PST

Created attachment 124428 [details] rebased patch for commit

WebKit Review Bot

Comment 8 2012-01-27 22:24:37 PST

Comment on attachment 124428 [details] rebased patch for commit Clearing flags on attachment: 124428 Committed r106183: <http://trac.webkit.org/changeset/106183>

Note You need to log in before you can comment on or make changes to this bug.