Bug 77235

Summary: Illegal panner model values should throw an exception
Product: WebKit Reporter: Raymond Toy <rtoy>
Component: Web AudioAssignee: Raymond Toy <rtoy>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, crogers, kbr, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77283    
Attachments:
Description Flags
Patch
none
Patch none

Description Raymond Toy 2012-01-27 12:45:52 PST 
Currently illegal values for the panner panningModel are silently accepted.  We should probably throw an exception for invalid values.
Comment 1 Raymond Toy 2012-02-01 13:49:21 PST 
Created attachment 125008 [details]
Patch
Comment 2 Raymond Toy 2012-02-01 14:19:00 PST 
Created attachment 125013 [details]
Patch
Comment 3 Raymond Toy 2012-02-01 14:21:07 PST 
Sorry. I forgot to update the test expectations because the panner-set-model test no longer crashes on debug builds.
Comment 4 Chris Rogers 2012-02-01 14:23:34 PST 
Looks good assuming bots pass.
Comment 5 Kenneth Russell 2012-02-02 08:25:32 PST 
Comment on attachment 125013 [details]
Patch

rs=me
Comment 6 Raymond Toy 2012-02-02 09:21:38 PST 
Comment on attachment 125013 [details]
Patch

Thanks for the review!
Comment 7 WebKit Review Bot 2012-02-02 12:29:36 PST 
Comment on attachment 125013 [details]
Patch

Clearing flags on attachment: 125013

Committed r106579: <http://trac.webkit.org/changeset/106579>
Comment 8 WebKit Review Bot 2012-02-02 12:29:42 PST 
All reviewed patches have been landed.  Closing bug.