Bug 77235 - Illegal panner model values should throw an exception
: Illegal panner model values should throw an exception
Status: RESOLVED FIXED
: WebKit
Web Audio
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 77283
  Show dependency treegraph
 
Reported: 2012-01-27 12:45 PST by
Modified: 2012-02-02 12:29 PST (History)


Attachments
Patch (7.38 KB, patch)
2012-02-01 13:49 PST, Raymond Toy
no flags Review Patch | Details | Formatted Diff | Diff
Patch (8.21 KB, patch)
2012-02-01 14:19 PST, Raymond Toy
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-01-27 12:45:52 PST
Currently illegal values for the panner panningModel are silently accepted.  We should probably throw an exception for invalid values.
------- Comment #1 From 2012-02-01 13:49:21 PST -------
Created an attachment (id=125008) [details]
Patch
------- Comment #2 From 2012-02-01 14:19:00 PST -------
Created an attachment (id=125013) [details]
Patch
------- Comment #3 From 2012-02-01 14:21:07 PST -------
Sorry. I forgot to update the test expectations because the panner-set-model test no longer crashes on debug builds.
------- Comment #4 From 2012-02-01 14:23:34 PST -------
Looks good assuming bots pass.
------- Comment #5 From 2012-02-02 08:25:32 PST -------
(From update of attachment 125013 [details])
rs=me
------- Comment #6 From 2012-02-02 09:21:38 PST -------
(From update of attachment 125013 [details])
Thanks for the review!
------- Comment #7 From 2012-02-02 12:29:36 PST -------
(From update of attachment 125013 [details])
Clearing flags on attachment: 125013

Committed r106579: <http://trac.webkit.org/changeset/106579>
------- Comment #8 From 2012-02-02 12:29:42 PST -------
All reviewed patches have been landed.  Closing bug.