Summary: | Add ElementAttributeData class to replace internal uses of NamedNodeMap | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||||||||
Component: | New Bugs | Assignee: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cmarcelo, darin, menard, rakuco, rniwa, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 75069 | ||||||||||||
Attachments: |
|
Description
Caio Marcelo de Oliveira Filho
2012-01-27 11:37:07 PST
Created attachment 124344 [details]
Patch
Created attachment 124364 [details]
Patch
(In reply to comment #2) > Created an attachment (id=124364) [details] > Patch To fix the win problem you need to add your file in CSSAllInOne.cpp. (In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=124364) [details] [details] > > Patch > > To fix the win problem you need to add your file in CSSAllInOne.cpp. Thanks! I think that's it. But in my case I think is dom/DOMAllInOne.cpp. I'm uploading a rebase version to check ;-) Created attachment 124576 [details]
Patch
Comment on attachment 124576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124576&action=review r=me, looks like a good place to start. Mac build needs fixing though. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:737 > + 2CF6878A14D32EFF00340F39 /* ElementAttributeData.h in Headers */ = {isa = PBXBuildFile; fileRef = 2CF6878914D32EFF00340F39 /* ElementAttributeData.h */; }; Needs "settings = {ATTRIBUTES = (Private, ); };" Created attachment 124657 [details]
Patch for landing
Comment on attachment 124657 [details] Patch for landing Clearing flags on attachment: 124657 Committed r106323: <http://trac.webkit.org/changeset/106323> All reviewed patches have been landed. Closing bug. |