Bug 77231

Summary: HTMLPreloadScanner should understand the <base> element
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: Page LoadingAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, eric, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
sketch (not working)
none
Patch
none
Patch for landing none

Description WebKit Review Bot 2012-01-27 11:00:50 PST 
HTMLPreloadScanner should understand the <base> element
Requested by abarth_ on #webkit.
Comment 1 Adam Barth 2012-01-27 17:41:28 PST 
Created attachment 124407 [details]
sketch (not working)
Comment 2 Adam Barth 2012-01-31 16:45:25 PST 
Created attachment 124848 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-01-31 17:35:35 PST 
Comment on attachment 124848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124848&action=review

LGTM.

> Source/WebCore/ChangeLog:9
> +        preloadnig resources.  If there was a <base> tag, this could cause the

ah preloadnig!

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:219
> +    // The first baseElementURL is the one that counts.

You probably want to say the first <base> element wins.
Comment 4 Adam Barth 2012-01-31 18:03:59 PST 
Created attachment 124863 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-01-31 20:08:10 PST 
Comment on attachment 124863 [details]
Patch for landing

Clearing flags on attachment: 124863

Committed r106426: <http://trac.webkit.org/changeset/106426>
Comment 6 WebKit Review Bot 2012-01-31 20:08:15 PST 
All reviewed patches have been landed.  Closing bug.