| Summary: | [Chromium] REGRESSION(r87067): WebFrame::setFindEndstateFocusAndSelection() doesn't set the selection for <input> and <textarea> | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
| Component: | HTML Editing | Assignee: | Kent Tamura <tkent> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dglazkov, dominicc, hayato, morrita | ||||
| Priority: | P1 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Kent Tamura
2012-01-26 22:15:32 PST
Created attachment 124265 [details]
Patch
Comment on attachment 124265 [details]
Patch
Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can give some intention revealing name for this kind of check.
(In reply to comment #2) > Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can give some intention revealing name for this kind of check. How about changing it to "if (host->isFocusable())" ? Does it make sense for non-builtin shadow DOM components? (In reply to comment #3) > (In reply to comment #2) > > Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can give some intention revealing name for this kind of check. > > How about changing it to "if (host->isFocusable())" ? Does it make sense for non-builtin shadow DOM components? I don't think it make sense for non-buitin shadow DOM components. I cannot see a clear reason to return host instead of an internal focusable element in case of non-builtin shadow DOM components. ok, I'm landing the patch as is for now. Comment on attachment 124265 [details] Patch Clearing flags on attachment: 124265 Committed r106216: <http://trac.webkit.org/changeset/106216> |