Bug 77176

Summary: Remove FIXME: ColorProfile encapsulation as a Vector<char> works well
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

noel gordon
Reported 2012-01-26 19:53:24 PST
Make ColorProfile a class and add static profile classification helpers
Attachments
Patch (6.12 KB, patch)
2012-01-26 19:59 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
Patch (1.22 KB, patch)
2012-01-26 22:29 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2012-01-26 19:59:42 PST
Created attachment 124245 [details] Patch
WebKit Review Bot
Comment 2 2012-01-26 20:01:23 PST
Attachment 124245 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/image-decoders/ImageDecoder.h:50: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
noel gordon
Comment 3 2012-01-26 20:01:56 PST
Will result in indentation nit, but the change is in keeping with the existing code style indentation.
noel gordon
Comment 4 2012-01-26 22:28:41 PST
On second thoughts, just remove the FIXME.
noel gordon
Comment 5 2012-01-26 22:29:28 PST
Created attachment 124264 [details] Patch
Adam Barth
Comment 6 2012-01-26 22:30:41 PST
Comment on attachment 124264 [details] Patch Ok
WebKit Review Bot
Comment 7 2012-01-26 23:52:56 PST
Comment on attachment 124264 [details] Patch Clearing flags on attachment: 124264 Committed r106097: <http://trac.webkit.org/changeset/106097>
WebKit Review Bot
Comment 8 2012-01-26 23:53:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.