Bug 77176 - Remove FIXME: ColorProfile encapsulation as a Vector<char> works well
Summary: Remove FIXME: ColorProfile encapsulation as a Vector<char> works well
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-26 19:53 PST by noel gordon
Modified: 2012-01-26 23:53 PST (History)
1 user (show)

See Also:

Attachments
Patch (6.12 KB, patch)
2012-01-26 19:59 PST, noel gordon 		no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2012-01-26 22:29 PST, noel gordon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2012-01-26 19:53:24 PST 
Make ColorProfile a class and add static profile classification helpers
Comment 1 noel gordon 2012-01-26 19:59:42 PST 
Created attachment 124245 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-26 20:01:23 PST 
Attachment 124245 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/image-decoders/ImageDecoder.h:50:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 noel gordon 2012-01-26 20:01:56 PST 
Will result in indentation nit, but the change is in keeping with the existing code style indentation.
Comment 4 noel gordon 2012-01-26 22:28:41 PST 
On second thoughts, just remove the FIXME.
Comment 5 noel gordon 2012-01-26 22:29:28 PST 
Created attachment 124264 [details]
Patch
Comment 6 Adam Barth 2012-01-26 22:30:41 PST 
Comment on attachment 124264 [details]
Patch

Ok
Comment 7 WebKit Review Bot 2012-01-26 23:52:56 PST 
Comment on attachment 124264 [details]
Patch

Clearing flags on attachment: 124264

Committed r106097: <http://trac.webkit.org/changeset/106097>
Comment 8 WebKit Review Bot 2012-01-26 23:53:00 PST 
All reviewed patches have been landed.  Closing bug.