Bug 77165 – JSC idl code generator generates bad code for [CachedAttribute] attributes

• Component: New Bugs
• Status: RESOLVED FIXED

[Pablo Flouret]

JSC idl code generator generates bad code for [CachedAttribute] attributes

[Pablo Flouret]

Created attachment 124223 [details]
Patch

[Oliver Hunt]

Comment on attachment 124223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124223&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3000
> +        return "$value ? $value->deserialize(exec, castedThis->globalObject(), 0) : jsNull()";

what is the additional argument here for?

[Pablo Flouret]

(In reply to comment #2)
> (From update of attachment 124223 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124223&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3000
> > +        return "$value ? $value->deserialize(exec, castedThis->globalObject(), 0) : jsNull()";
> 
> what is the additional argument here for?

MessagePortArray*

MessageEvent (the only one declaring CachedAttributes so far) uses a custom getter, so i imagine that's why this has gone unnoticed.

[WebKit Review Bot]

Comment on attachment 124223 [details]
Patch

Clearing flags on attachment: 124223

Committed r106077: <http://trac.webkit.org/changeset/106077>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.