| Summary: | JSC idl code generator generates bad code for [CachedAttribute] attributes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pablo Flouret <pf> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, haraken, japhet, oliver, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 76035 | ||||||
| Attachments: |
|
||||||
|
Description
Pablo Flouret
2012-01-26 17:22:51 PST
Created attachment 124223 [details]
Patch
Comment on attachment 124223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124223&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3000 > + return "$value ? $value->deserialize(exec, castedThis->globalObject(), 0) : jsNull()"; what is the additional argument here for? (In reply to comment #2) > (From update of attachment 124223 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124223&action=review > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3000 > > + return "$value ? $value->deserialize(exec, castedThis->globalObject(), 0) : jsNull()"; > > what is the additional argument here for? MessagePortArray* MessageEvent (the only one declaring CachedAttributes so far) uses a custom getter, so i imagine that's why this has gone unnoticed. Comment on attachment 124223 [details] Patch Clearing flags on attachment: 124223 Committed r106077: <http://trac.webkit.org/changeset/106077> All reviewed patches have been landed. Closing bug. |