Bug 77163

Summary:	MacroAssemblerCodeRef.h uses OS(WIN) instead of OS(WINDOWS)
Product:	WebKit	Reporter:	David Levin <levin>
Component:	JavaScriptCore	Assignee:	Gavin Barraclough <barraclough>
Status:	RESOLVED FIXED
Severity:	Normal
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	77162

David Levin

Reported 2012-01-26 16:57:15 PST

Looks like it was introduced in http://trac.webkit.org/changeset/97189 The fix is trivial but I'm a little worried about just changing this (since I don't use this platform).

Attachments
Add attachment proposed patch, testcase, etc.

David Levin

Comment 1 2012-01-30 12:24:57 PST

Note that OS(WIN) is never defined so the code in this if isn't used. My patch in 77162 will make code fail to build if it uses OS(WIN). It is easy to make this mistake (and I did it as well) because there is a PLATFORM(WIN).

Gavin Barraclough

Comment 2 2012-01-30 12:58:43 PST

Fixed in r106277

Note You need to log in before you can comment on or make changes to this bug.