Bug 77161

Summary: Add API to get the parent frame in WKBundleFrameRef
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Implementation + test andersca: review+

Ada Chan
Reported 2012-01-26 16:28:07 PST
Add WKBundleFrameGetParentFrame(). This is needed for <rdar://problem/10421393>.
Attachments
Implementation + test (18.24 KB, patch)
2012-01-26 16:45 PST, Ada Chan 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2012-01-26 16:45:28 PST
Created attachment 124214 [details] Implementation + test
Anders Carlsson
Comment 2 2012-01-26 16:52:13 PST
Comment on attachment 124214 [details] Implementation + test View in context: https://bugs.webkit.org/attachment.cgi?id=124214&action=review > Tools/TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:64 > + assert(childFrame); > + bool isParentFrameCheckSuccessful = childFrame ? WKBundleFrameGetParentFrame(childFrame.get()) == frame : false; You have both an assert and a null check here, do you really need the assert?
Ada Chan
Comment 3 2012-01-27 11:42:44 PST
I removed the assert. Thanks for reviewing! Committed: http://trac.webkit.org/changeset/106139
Note You need to log in before you can comment on or make changes to this bug.