Bug 77145

Summary:

[JSC] Some JS_EXPORTDATA may not be necessary.

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

Tools / Tests

Assignee:

Hajime Morrita <morrita>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, kevino, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

77275

Bug Blocks:

72854

Attachments:

Description	Flags
Patch	none

Description Hajime Morrita 2012-01-26 14:53:27 PST

This is derived from Bug 72854.
Some JSC classes have s_info static class variables
which are marked as JS_EXPORTDATA. But these may not be necessary.
In this bug, we are going to investigate if we can remove them.

Comment 1 Hajime Morrita 2012-01-27 11:17:33 PST

Created attachment 124339 [details]
Patch

Comment 2 Hajime Morrita 2012-01-27 11:20:46 PST

SInce I'm visiting a remote office I cannot check this on Windows for now.
But I feel that we can see the obvious consequence on the bot...
This patch is so small and it would be easy to rollout if the bot fails.

Comment 3 Hajime Morrita 2012-01-27 11:23:07 PST

Hi Darin and Kevin,
Could you rubberstamp this small symbol adjustment stuff?

Comment 4 WebKit Review Bot 2012-01-27 14:41:08 PST

Comment on attachment 124339 [details]
Patch

Clearing flags on attachment: 124339

Committed r106151: <http://trac.webkit.org/changeset/106151>

Comment 5 WebKit Review Bot 2012-01-27 14:41:12 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Hajime Morrita 2012-01-27 15:05:57 PST

Hmm Apple win bots are so red today that I cannot confirm that this patch works well...
Please feel free to revert this if this has any possible problem/is suspicious in any level.