| Summary: | run-perf-test should include relative file paths in test names | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, eric, morrita, ojan, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 77037 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2012-01-26 14:51:20 PST
Created attachment 124192 [details]
fixes the bug
Comment on attachment 124192 [details]
fixes the bug
ok. How MacOS 9 of you!
Comment on attachment 124192 [details]
fixes the bug
Do we have to follow the chromium perf bot convention? It would seem better to follow the webkit conventions for test names and use '/'.
(In reply to comment #3) > (From update of attachment 124192 [details]) > Do we have to follow the chromium perf bot convention? It would seem better to follow the webkit conventions for test names and use '/'. We could but we don't have to match layout tests' convention either though. Is there any reason using '/' as the delimiter is better? (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 124192 [details] [details]) > > Do we have to follow the chromium perf bot convention? It would seem better to follow the webkit conventions for test names and use '/'. > > We could but we don't have to match layout tests' convention either though. Is there any reason using '/' as the delimiter is better? It seems to me that having a single convention used by the tools in a single code base would be better. That way I don't have to remember that it's run-webkit-tests fast/html but run-perf-tests fast:html . I type this now realizing that what is in the JSON file is not necessarily what's on the command line, but it seems to me that being uniform is good, and if test names get displayed on a web page I would want them to display as "/" to match the other tools. If the chromium perf test store "foo:bar" but display "foo/bar", then ":" is fine by me. (In reply to comment #5) > If the chromium perf test store "foo:bar" but display "foo/bar", then ":" is fine by me. Well, "fine" might be a bit strong; I'd probably still grumble a little over it being different :). I guess being able to copy & paste test name is a strong argument. Will change it to /. |