Bug 77109

Summary: WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Caio Marcelo de Oliveira Filho
Reported 2012-01-26 09:44:40 PST
Wrap static HashMap inside a function and use DEFINE_STATIC_LOCAL
Attachments
Patch (2.73 KB, patch)
2012-01-26 09:48 PST, Caio Marcelo de Oliveira Filho 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2012-01-26 09:45:39 PST
This should fix build for Clang.
Caio Marcelo de Oliveira Filho
Comment 2 2012-01-26 09:48:31 PST
Created attachment 124131 [details] Patch
Andreas Kling
Comment 3 2012-01-26 09:49:29 PST
Comment on attachment 124131 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124131&action=review > Source/WebKit2/Shared/WebPreferencesStore.cpp:188 > + HashMap<String, bool>::const_iterator it = boolTestRunnerOverridesMap().find(key); You could use BoolOverridesMap::const_iterator here for style points.
Caio Marcelo de Oliveira Filho
Comment 4 2012-01-26 09:59:30 PST
Committed r106008: <http://trac.webkit.org/changeset/106008>
Note You need to log in before you can comment on or make changes to this bug.