Bug 77109

Summary: WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Caio Marcelo de Oliveira Filho 2012-01-26 09:44:40 PST
Wrap static HashMap inside a function and use DEFINE_STATIC_LOCAL
Comment 1 Caio Marcelo de Oliveira Filho 2012-01-26 09:45:39 PST
This should fix build for Clang.
Comment 2 Caio Marcelo de Oliveira Filho 2012-01-26 09:48:31 PST
Created attachment 124131 [details]
Patch
Comment 3 Andreas Kling 2012-01-26 09:49:29 PST
Comment on attachment 124131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124131&action=review

> Source/WebKit2/Shared/WebPreferencesStore.cpp:188
> +    HashMap<String, bool>::const_iterator it = boolTestRunnerOverridesMap().find(key);

You could use BoolOverridesMap::const_iterator here for style points.
Comment 4 Caio Marcelo de Oliveira Filho 2012-01-26 09:59:30 PST
Committed r106008: <http://trac.webkit.org/changeset/106008>