Bug 77107

Summary:

[EFL] Introducing functions to set local storage db path and clear those dbs.

Product:

WebKit

Reporter:

Gustavo Lima Chaves <glima>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adauria, darin, gyuyoung.kim, leandro, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

77006

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Gustavo Lima Chaves

Reported 2012-01-26 09:16:00 PST

[EFL] Introducing functions to set local storage db path and clear those dbs.

Attachments
Patch (6.43 KB, patch) 2012-01-26 09:16 PST, Gustavo Lima Chaves	no flags	Details Formatted Diff Diff
Patch (9.77 KB, patch) 2012-02-02 08:24 PST, Gustavo Lima Chaves	no flags	Details Formatted Diff Diff
Patch (10.00 KB, patch) 2012-02-06 05:13 PST, Gustavo Lima Chaves	no flags	Details Formatted Diff Diff
Patch (10.05 KB, patch) 2012-02-09 08:41 PST, Gustavo Lima Chaves	no flags	Details Formatted Diff Diff
Patch (10.05 KB, patch) 2012-02-09 09:37 PST, Gustavo Lima Chaves	no flags	Details Formatted Diff Diff
Patch (10.09 KB, patch) 2012-02-09 10:10 PST, Gustavo Lima Chaves	no flags	Details Formatted Diff Diff
Patch (10.07 KB, patch) 2012-02-09 10:13 PST, Gustavo Lima Chaves	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Gustavo Lima Chaves

Comment 1 2012-01-26 09:16:30 PST

Created attachment 124127 [details] Patch

Gustavo Lima Chaves

Comment 2 2012-02-02 05:24:38 PST

Anton, Darin: Now that you approved my StorageTracker WebCore changes, would you please kindly review the use of it at the EFL port? Thank you, in advance.

Gyuyoung Kim

Comment 3 2012-02-02 06:02:12 PST

Comment on attachment 124127 [details] Patch Attachment 124127 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11386819

Gustavo Lima Chaves

Comment 4 2012-02-02 08:24:07 PST

Created attachment 125136 [details] Patch

Gustavo Lima Chaves

Comment 5 2012-02-02 08:24:53 PST

(In reply to comment #4) > Created an attachment (id=125136) [details] > Patch Sorry, 1st time using webkit-patch with new files, now done right.

Gyuyoung Kim

Comment 6 2012-02-04 20:22:23 PST

Comment on attachment 125136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125136&action=review > Source/WebKit/efl/ChangeLog:7 > + Missing description for this patch. > Source/WebKit/efl/ewk/ewk_settings.h:101 > + * I think this is unneeded line.

Gustavo Lima Chaves

Comment 7 2012-02-06 05:13:37 PST

Created attachment 125620 [details] Patch

Gustavo Lima Chaves

Comment 8 2012-02-06 05:17:29 PST

(In reply to comment #6) > > > Source/WebKit/efl/ChangeLog:7 > > + > > Missing description for this patch. OK, added more description of the work. > > > Source/WebKit/efl/ewk/ewk_settings.h:101 > > + * > > I think this is unneeded line. Removed.

Gustavo Lima Chaves

Comment 9 2012-02-07 05:02:27 PST

(In reply to comment #8) Does the patch look OK, Anton & Darin?

Kenneth Rohde Christiansen

Comment 10 2012-02-09 08:31:37 PST

Comment on attachment 125620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125620&action=review Looks ok > Source/WebKit/efl/ChangeLog:6 > + This patch exposes the web local storage tracker database path setting cabability, introduced on bug 77006, to the EFL port of WebKit. Particularly, we have our own storage tracker client object, to initialize the storage tracker backend on ewk_init(). please split (max 80 - 100 chars)

Gustavo Lima Chaves

Comment 11 2012-02-09 08:41:15 PST

Created attachment 126311 [details] Patch

Gustavo Lima Chaves

Comment 12 2012-02-09 08:42:09 PST

(In reply to comment #10) > > please split (max 80 - 100 chars) Done. Thank you very much, Kenneth :)

Gustavo Lima Chaves

Comment 13 2012-02-09 09:37:12 PST

Created attachment 126318 [details] Patch

Gustavo Lima Chaves

Comment 14 2012-02-09 10:10:06 PST

Created attachment 126323 [details] Patch