Bug 77071

Summary: Revert code changes from r105800
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: New BugsAssignee: Daniel Cheng <dcheng>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Daniel Cheng
Reported 2012-01-25 21:54:42 PST
Revert code changes from r105800
Attachments
Patch (1.65 KB, patch)
2012-01-25 21:55 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2012-01-26 09:01 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2012-01-25 21:55:37 PST
Created attachment 124062 [details] Patch
Jessie Berlin
Comment 2 2012-01-26 08:54:06 PST
Comment on attachment 124062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124062&action=review So the test you added in http://trac.webkit.org/changeset/105800 would have passed without the code change? Unofficial r=me (not a reviewer yet). > Source/WebCore/ChangeLog:6 > + The strings are already lowercased before they make their way to this function, so there's Might be nice to say where they get lowercased. > Source/WebCore/dom/Clipboard.cpp:215 > + Looks like extra space snuck in here.
Daniel Cheng
Comment 3 2012-01-26 09:01:54 PST
Created attachment 124124 [details] Patch
Daniel Cheng
Comment 4 2012-01-26 09:03:09 PST
Comment on attachment 124062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124062&action=review Yes, the test passes without this change. There was another change in the original CL as well and when I moved that change to another patch, I didn't check if the remaining code changes were still needed. >> Source/WebCore/ChangeLog:6 >> + The strings are already lowercased before they make their way to this function, so there's > > Might be nice to say where they get lowercased. Done. >> Source/WebCore/dom/Clipboard.cpp:215 >> + > > Looks like extra space snuck in here. This was in the original change, but I went ahead and cleaned it up.
WebKit Review Bot
Comment 5 2012-01-26 11:23:59 PST
Comment on attachment 124124 [details] Patch Clearing flags on attachment: 124124 Committed r106018: <http://trac.webkit.org/changeset/106018>
WebKit Review Bot
Comment 6 2012-01-26 11:24:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.