| Summary: | Parsing test_expecations.txt + Skipped lists takes too long | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dpranke, eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 77142 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Ojan Vafai
2012-01-25 16:48:55 PST
Created attachment 124035 [details]
Patch
Comment on attachment 124035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124035&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:855 > + for test in self._parser.parse_skipped_tests(tests_to_skip): Nit: I would iterate directly over tests_to_skip here and change parse_skipped_tests to something like expectation_for_skipped_test(index, test). Looks fine otherwise. I'm a bit surprised it's this slow, but there is so much python-level path handling in the code that I'm not that surprised. You should see how slow the MockFileSystem makes the unit tests :). Committed r106038: <http://trac.webkit.org/changeset/106038> Reopening to attach new patch. Created attachment 124215 [details]
Patch
This was reverted in https://bugs.webkit.org/show_bug.cgi?id=77142. The bug was the we were missing a BUG modifier and were thus getting errors on each line and ignoring them. Fixed this and added a test to verify that we're actually ending up with the skipped tests expected to be skipped. Comment on attachment 124215 [details] Patch Clearing flags on attachment: 124215 Committed r106293: <http://trac.webkit.org/changeset/106293> All reviewed patches have been landed. Closing bug. |