Bug 77059

Summary: Parsing test_expecations.txt + Skipped lists takes too long
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 77142    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Ojan Vafai
Reported 2012-01-25 16:48:55 PST
Parsing test_expecations.txt + Skipped lists takes too long
Attachments
Patch (7.96 KB, patch)
2012-01-25 16:50 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (10.03 KB, patch)
2012-01-26 16:46 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-01-25 16:50:50 PST
Created attachment 124035 [details] Patch
Dirk Pranke
Comment 2 2012-01-25 16:59:25 PST
Comment on attachment 124035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124035&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:855 > + for test in self._parser.parse_skipped_tests(tests_to_skip): Nit: I would iterate directly over tests_to_skip here and change parse_skipped_tests to something like expectation_for_skipped_test(index, test). Looks fine otherwise. I'm a bit surprised it's this slow, but there is so much python-level path handling in the code that I'm not that surprised. You should see how slow the MockFileSystem makes the unit tests :).
Ojan Vafai
Comment 3 2012-01-26 13:46:55 PST
Committed r106038: <http://trac.webkit.org/changeset/106038>
Ojan Vafai
Comment 4 2012-01-26 16:46:55 PST
Reopening to attach new patch.
Ojan Vafai
Comment 5 2012-01-26 16:46:57 PST
Created attachment 124215 [details] Patch
Ojan Vafai
Comment 6 2012-01-26 16:47:57 PST
This was reverted in https://bugs.webkit.org/show_bug.cgi?id=77142. The bug was the we were missing a BUG modifier and were thus getting errors on each line and ignoring them. Fixed this and added a test to verify that we're actually ending up with the skipped tests expected to be skipped.
WebKit Review Bot
Comment 7 2012-01-30 15:16:26 PST
Comment on attachment 124215 [details] Patch Clearing flags on attachment: 124215 Committed r106293: <http://trac.webkit.org/changeset/106293>
WebKit Review Bot
Comment 8 2012-01-30 15:16:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.