| Summary: | Web Inspector: tests in PerformanceTests/inspector/ are timing out | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, commit-queue, dpranke, glenn, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys, zoltan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 77037 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryosuke Niwa
2012-01-25 10:11:49 PST
Skipped them in http://trac.webkit.org/changeset/106312 temporarily since run-perf-tests will spend 4+ minutes on each test when a test times out. The root of problem is that we have no Inspector's tests support on Chromium Mac platform. (In reply to comment #2) > The root of problem is that we have no Inspector's tests support on Chromium Mac platform. That sounds really bad. Can we add it? (In reply to comment #3) > (In reply to comment #2) > > The root of problem is that we have no Inspector's tests support on Chromium Mac platform. > > That sounds really bad. Can we add it? I'll try to do that. Is it possible to disable the tests only for mac platform? (In reply to comment #4) > I'll try to do that. > > Is it possible to disable the tests only for mac platform? Not at the moment :( layout-test-style skipped list or test_expectations.txt won't work here because we don't have a platform directory. But we can safely assume all perf bots are on Mac for now since I haven't heard anything about adding win/linux bot from the infrastructure team although I'm also intending to ping Qt/GTK folks. It might be a good idea to add --force option so that you can run skipped tests locally though. (In reply to comment #5) > It might be a good idea to add --force option so that you can run skipped tests locally though. I filed it: bug #90279 Some tests are not timeouting for me on Qt anymore: Pass: Running inspector/console-300-lines.html (1 of 7) Running inspector/first-open-elements.html (2 of 7) Running inspector/first-open-resources.html (3 of 7) Running inspector/inspector-startup-time.html (6 of 7) Timeout: Running inspector/heap-snapshot-advanced.html (4 of 7) Running inspector/heap-snapshot.html (5 of 7) Fail: Running inspector/native-memory-snapshot.html (7 of 7) Ilya, was there any progress on Mac-Chromium inspector support? Created attachment 178204 [details]
Patch
(In reply to comment #7) > Some tests are not timeouting for me on Qt anymore: > > Pass: > Running inspector/console-300-lines.html (1 of 7) > Running inspector/first-open-elements.html (2 of 7) > Running inspector/first-open-resources.html (3 of 7) > Running inspector/inspector-startup-time.html (6 of 7) > > Timeout: > Running inspector/heap-snapshot-advanced.html (4 of 7) > Running inspector/heap-snapshot.html (5 of 7) > > Fail: > Running inspector/native-memory-snapshot.html (7 of 7) > > Ilya, was there any progress on Mac-Chromium inspector support? I've fixed the problem with chromium-mac but heap-snapshot* tests wouldn't work in non-chromium WebKit ports. (In reply to comment #9) > > I've fixed the problem with chromium-mac but heap-snapshot* tests wouldn't work in non-chromium WebKit ports. Great, thanks! Can you explain me the situation with the heap-snapshot tests? (What do we need to do to get these work on non-chromium ports?) Comment on attachment 178204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178204&action=review > PerformanceTests/ChangeLog:8 > + It was fixed in downstream patch r171707. Does it work on non-Chromium ports? run-perf-tests doesn’t support per-port skipped list. If any of the tests don’t pass on non-Chromium ports, then we have to skip them on bots. Also, we might want to consider adopting the perf. test framework used by other perf. tests instead of using chromium perf-bot style output. runner.js has improved considerably in the last six months. Comment on attachment 178204 [details]
Patch
It appears that we shouldn’t land this patch since some of the tests wouldn’t run on non-Chromium ports.
(In reply to comment #11) > (From update of attachment 178204 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178204&action=review > > > PerformanceTests/ChangeLog:8 > > + It was fixed in downstream patch r171707. > > Does it work on non-Chromium ports? run-perf-tests doesn’t support per-port skipped list. If any of the tests don’t pass on non-Chromium ports, then we have to skip them on bots. > Also, we might want to consider adopting the perf. test framework used by other perf. tests instead of using chromium perf-bot style output. > runner.js has improved considerably in the last six months. Is there a chance to support port specific skip list or even support current TestExpectation format? (In reply to comment #10) > (In reply to comment #9) > > > > I've fixed the problem with chromium-mac but heap-snapshot* tests wouldn't work in non-chromium WebKit ports. > > Great, thanks! > > Can you explain me the situation with the heap-snapshot tests? (What do we need to do to get these work on non-chromium ports?) You need to implement detailed heap snapshot for JSC engine. It is a bit complex task. Each memory fragment separately allocated by JSC should be reported as a snapshot node with id, size, type, name and edges count. Also all the links from the fragment to other fragments should be reported as snapshot edges with type, name and to_node_id. Id consistency: The node id that was assigned to a memory fragment when you took a snapshot has to be the same in the second snapshot even if the memory fragment was moved by GC. Also you can report an array of strings and their indexes can be used as node names and edge names. (In reply to comment #13) > (In reply to comment #11) > > (From update of attachment 178204 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=178204&action=review > > > > > PerformanceTests/ChangeLog:8 > > > + It was fixed in downstream patch r171707. > > > > Does it work on non-Chromium ports? run-perf-tests doesn’t support per-port skipped list. If any of the tests don’t pass on non-Chromium ports, then we have to skip them on bots. > > Also, we might want to consider adopting the perf. test framework used by other perf. tests instead of using chromium perf-bot style output. > > runner.js has improved considerably in the last six months. > > Is there a chance to support port specific skip list or even support current TestExpectation format? No. We don’t have platforms directory so I’m not even sure how we’d support that, and adding platforms directly just to support Skipped/TestExpectations files seems rather silly. Created attachment 203321 [details]
Delete tests for now
Comment on attachment 203321 [details]
Delete tests for now
rs=me
Comment on attachment 203321 [details] Delete tests for now Clearing flags on attachment: 203321 Committed r150955: <http://trac.webkit.org/changeset/150955> All reviewed patches have been landed. Closing bug. |