Summary: | Remote web inspector reentrancy fixes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leo Franchi <leo> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | jesus, jturcotte, kenneth, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Leo Franchi
2012-01-25 10:01:51 PST
Created attachment 123965 [details]
Patch
The direct connection caused the tcp socket to no longer accept incoming events when waiting on a breakpoint. It looks fine to me. Kenneth, could you have a look too? Comment on attachment 123965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123965&action=review > Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:364 > #if ENABLE(INSPECTOR) A separate issue, but maybe the whole file/class should be in this enable. The InspectorServer would be pretty useless without ENABLE(INSPECTOR) =) r=me, this patch looks good to me. cq+ as requested by Leo Franchi on IRC. Comment on attachment 123965 [details] Patch Clearing flags on attachment: 123965 Committed r107085: <http://trac.webkit.org/changeset/107085> All reviewed patches have been landed. Closing bug. |