Bug 76982

Summary: File extension for webp files is .webp
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, pascal.massimino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description noel gordon 2012-01-24 22:41:45 PST
File extension for webp files is .webp
Comment 1 noel gordon 2012-01-24 22:42:50 PST
Created attachment 123886 [details]
Patch
Comment 2 Adam Barth 2012-01-24 23:28:09 PST
Comment on attachment 123886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123886&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. No change in behavior.

This doesn't change behavior?  Is this change observable somehow?
Comment 3 Adam Barth 2012-01-24 23:29:09 PST
Comment on attachment 123886 [details]
Patch

I'm marking this r+ in case there isn't a way to test this (referring to our earlier conversation about timezones causing 24hr latency on questions).  However, if there is a way to test this change, we should include a test.  That might require digging a bit to understand what this function is used for.
Comment 4 noel gordon 2012-01-24 23:42:17 PST
> This doesn't change behavior?  Is this change observable somehow?

Ran layout tests locally on mac, no changes observed.  Not sure how we'd observe this change.
Comment 5 Adam Barth 2012-01-24 23:43:45 PST
> Ran layout tests locally on mac, no changes observed.  Not sure how we'd observe this change.

We'll need to look at the callers of this function to understand what they're using this information for and craft a test that exercises them.  If no one uses this information for anything observable, we should remove the function.
Comment 6 noel gordon 2012-01-25 14:33:02 PST
Thanks Adam. I'm OOO today and will dig around as you suggested Friday my time.
Comment 7 noel gordon 2012-01-26 14:54:20 PST
filenameExtension() was added to BitmapImage{.h.cpp} in http://trac.webkit.org/changeset/39185 to resolve bug 20685.  A manual test was added at that time.  I can't access the bug, the code change hints at some security issue with drag drop.
Comment 8 Adam Barth 2012-01-26 15:00:33 PST
We can problem unprotect that bug as this point, but this isn't really testable in an automated way.  Thanks for tracking it down.
Comment 9 WebKit Review Bot 2012-01-26 15:44:37 PST
Comment on attachment 123886 [details]
Patch

Clearing flags on attachment: 123886

Committed r106055: <http://trac.webkit.org/changeset/106055>
Comment 10 WebKit Review Bot 2012-01-26 15:44:42 PST
All reviewed patches have been landed.  Closing bug.