Bug 76962

Summary: garden-o-matic pixel zoomer should let you look at every pixel of the image
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, leviw, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ojan: review+

Description Adam Barth 2012-01-24 16:40:45 PST 
garden-o-matic pixel zoomer should let you look at every pixel of the image
Comment 1 Adam Barth 2012-01-24 16:43:00 PST 
Created attachment 123841 [details]
Patch
Comment 2 Levi Weintraub 2012-01-24 16:45:43 PST 
Comment on attachment 123841 [details]
Patch

LGTM, but you'll need a real reviewer ;)
Comment 3 Ojan Vafai 2012-01-24 16:49:41 PST 
Comment on attachment 123841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123841&action=review

Extra points if you fix the pixel zoomer in results.html as well. :)

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:107
> +    image.style.left = -(pixelzoomer._percentX * kZoomedResultWidth) + containerBounds.width/2 + 'px';
> +    image.style.top = -(pixelzoomer._percentY * kZoomedResultHeight) + containerBounds.height/2 + 'px';

Nit: Need spaces around the /. I'd also wrap the whole equation in parens to make it clear which part is math and which part is string concat.
Comment 4 Adam Barth 2012-01-24 16:56:28 PST 
Committed r105834: <http://trac.webkit.org/changeset/105834>
Comment 5 Adam Barth 2012-01-24 17:04:28 PST 
Oops.  I missed your comments before landing.  Will fix.