RESOLVED FIXED76962
garden-o-matic pixel zoomer should let you look at every pixel of the image 
https://bugs.webkit.org/show_bug.cgi?id=76962
Summary garden-o-matic pixel zoomer should let you look at every pixel of the image
Adam Barth
Reported 2012-01-24 16:40:45 PST
garden-o-matic pixel zoomer should let you look at every pixel of the image
Attachments
Patch (3.56 KB, patch)
2012-01-24 16:43 PST, Adam Barth 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-24 16:43:00 PST
Created attachment 123841 [details] Patch
Levi Weintraub
Comment 2 2012-01-24 16:45:43 PST
Comment on attachment 123841 [details] Patch LGTM, but you'll need a real reviewer ;)
Ojan Vafai
Comment 3 2012-01-24 16:49:41 PST
Comment on attachment 123841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123841&action=review Extra points if you fix the pixel zoomer in results.html as well. :) > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:107 > + image.style.left = -(pixelzoomer._percentX * kZoomedResultWidth) + containerBounds.width/2 + 'px'; > + image.style.top = -(pixelzoomer._percentY * kZoomedResultHeight) + containerBounds.height/2 + 'px'; Nit: Need spaces around the /. I'd also wrap the whole equation in parens to make it clear which part is math and which part is string concat.
Adam Barth
Comment 4 2012-01-24 16:56:28 PST
Committed r105834: <http://trac.webkit.org/changeset/105834>
Adam Barth
Comment 5 2012-01-24 17:04:28 PST
Oops. I missed your comments before landing. Will fix.
Note You need to log in before you can comment on or make changes to this bug.