Bug 76949
| Summary: | check-webkit-style warns about ; inside quotation marks for python code. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | dpranke |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
check-webkit-style erroneously complains about having multiple statements for the patch on https://bugs.webkit.org/show_bug.cgi?id=76312 due to ; appearing inside single quotation marks.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
Code is here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py and not too hard for new comers to change/fix as eae@chromium.org just demonstrated.
David Levin
Whoops, this is about python code. For that WebKit just uses an external package.
http://pypi.python.org/pypi/pep8
So it can't be fixed inside of WebKit. It would be best to follow up there if you want it fixed. It is referenced here: Tools/Scripts/webkitpy/thirdparty/__init__.py