Summary: | Change dispatchIntent API to pure virtual in FrameLoaderClient. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Greg Billock <gbillock> | ||||
Component: | New Bugs | Assignee: | Greg Billock <gbillock> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 75123 | ||||||
Attachments: |
|
Description
Greg Billock
2012-01-24 13:24:57 PST
Created attachment 123792 [details]
Patch
Comment on attachment 123792 [details]
Patch
Ok. I'm not sure I fully understand why, but this change is fine.
(In reply to comment #2) > (From update of attachment 123792 [details]) > Ok. I'm not sure I fully understand why, but this change is fine. It looks like all our other compilers have no problems with this. The Windows error message is that PassRefPtr.h needs the WebCore::IntentRequest object to be fully defined in order to do ->deref() on the type. As a guess, the compiler is trying to do codegen for the empty method when others don't need to? (The errors are from includes in Document.cpp and DOMImplementation.cpp, which don't call that method. I don't develop on Windows, so I'm depending on others' expertise here... Comment on attachment 123792 [details] Patch Clearing flags on attachment: 123792 Committed r105812: <http://trac.webkit.org/changeset/105812> All reviewed patches have been landed. Closing bug. |