Bug 76940

Summary: Change dispatchIntent API to pure virtual in FrameLoaderClient.
Product: WebKit Reporter: Greg Billock <gbillock>
Component: New BugsAssignee: Greg Billock <gbillock>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75123    
Attachments:
Description Flags
Patch none

Greg Billock
Reported 2012-01-24 13:24:57 PST
Change dispatchIntent API to pure virtual in FrameLoaderClient.
Attachments
Patch (2.28 KB, patch)
2012-01-24 13:26 PST, Greg Billock 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Greg Billock
Comment 1 2012-01-24 13:26:31 PST
Created attachment 123792 [details] Patch
Adam Barth
Comment 2 2012-01-24 13:28:17 PST
Comment on attachment 123792 [details] Patch Ok. I'm not sure I fully understand why, but this change is fine.
Greg Billock
Comment 3 2012-01-24 13:39:04 PST
(In reply to comment #2) > (From update of attachment 123792 [details]) > Ok. I'm not sure I fully understand why, but this change is fine. It looks like all our other compilers have no problems with this. The Windows error message is that PassRefPtr.h needs the WebCore::IntentRequest object to be fully defined in order to do ->deref() on the type. As a guess, the compiler is trying to do codegen for the empty method when others don't need to? (The errors are from includes in Document.cpp and DOMImplementation.cpp, which don't call that method. I don't develop on Windows, so I'm depending on others' expertise here...
WebKit Review Bot
Comment 4 2012-01-24 14:36:15 PST
Comment on attachment 123792 [details] Patch Clearing flags on attachment: 123792 Committed r105812: <http://trac.webkit.org/changeset/105812>
WebKit Review Bot
Comment 5 2012-01-24 14:36:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.