Bug 76928

Summary: Accelerated drawing should force compositing mode
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: PlatformAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Beth Dakin
Reported 2012-01-24 11:26:57 PST
Accelerated drawing should force compositing mode. Patch forthcoming. <rdar://problem/10697417>
Attachments
Patch (2.62 KB, patch)
2012-01-24 11:29 PST, Beth Dakin 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2012-01-24 11:29:05 PST
Created attachment 123776 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-01-24 13:56:23 PST
Comment on attachment 123776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123776&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1856 > + if (settings->acceleratedDrawingEnabled()) > + settings->setForceCompositingMode(LayerTreeHost::supportsAcceleratedCompositing()); > + else > + settings->setForceCompositingMode(store.getBoolValueForKey(WebPreferencesKey::forceCompositingModeKey()) && LayerTreeHost::supportsAcceleratedCompositing()); This should probably be #if PLATFORM(MAC), and I think it deserves a comment or reference to a radar.
Beth Dakin
Comment 3 2012-01-24 14:11:11 PST
Thanks Simon! I made it Mac-only, and I added a comment as well. Committed change: http://trac.webkit.org/changeset/105806
Note You need to log in before you can comment on or make changes to this bug.