Bug 76922

Summary:

CodeGeneratorJS.pm should overwrite the output .h/.cpp only if the bytes differ

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

76836

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2012-01-24 09:51:38 PST

This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836).

In this bug, we make a change on CodeGeneratorJS.pm so that it overwrites the output .h/.cpp only if the bytes differ.

Comment 1 Kentaro Hara 2012-01-24 10:01:35 PST

Created attachment 123758 [details]
Patch

Comment 2 WebKit Review Bot 2012-01-24 14:01:03 PST

Comment on attachment 123758 [details]
Patch

Rejecting attachment 123758 [details] from commit-queue.

New failing tests:
media/audio-garbage-collect.html
Full output: http://queues.webkit.org/results/11177053

Comment 3 WebKit Review Bot 2012-01-24 14:24:17 PST

Comment on attachment 123758 [details]
Patch

Clearing flags on attachment: 123758

Committed r105809: <http://trac.webkit.org/changeset/105809>

Comment 4 WebKit Review Bot 2012-01-24 14:24:21 PST

All reviewed patches have been landed.  Closing bug.