Bug 76919
| Summary: | AudioParamTimeline functions should use doubles for time variables | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Raymond Toy <rtoy> |
| Component: | Web Audio | Assignee: | Raymond Toy <rtoy> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | crogers |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 77666 | ||
| Bug Blocks: | 78854, 100885 | ||
Raymond Toy
Many of the functions in the AudioParamTimeline class take floats for the time variables. They should probably take doubles to minimize round-off issues. See, for example, bug 76073 and bug 76659.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Rogers
Please switch to doubles in the IDL unless this is extremely difficult to reconcile with the math.
Raymond Toy
(In reply to comment #1)
> Please switch to doubles in the IDL unless this is extremely difficult to reconcile with the math.
Do you mean only in the IDL or the IDL in addition to the c++ code? It would be best to use doubles in the c++ code and the IDL.
Raymond Toy
It would be best to do this after bug 77666 which adds tests for AudioParam. Then we can see what impact this change will have.
Chris Rogers
Fixed in:
http://trac.webkit.org/changeset/133365