Summary: | [WK2] [GTK] TestDownloads hitting an assertion in Debug builds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
Component: | WebKitGTK | Assignee: | Sergio Villar Senin <svillar> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, svillar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Sergio Villar Senin
2012-01-24 07:58:54 PST
Created attachment 123735 [details]
Patch
Comment on attachment 123735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123735&action=review Yeah, my fault, sorry, Patch is correct, except the m_resourceHandle in Download::startWithHandle > Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:145 > - ASSERT(m_downloadClient); > + ASSERT(!m_downloadClient); > ASSERT(m_resourceHandle); This should be !m_resourceHandle, since it's assigned to resourceHandle below (In reply to comment #2) > (From update of attachment 123735 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123735&action=review > > Yeah, my fault, sorry, Patch is correct, except the m_resourceHandle in Download::startWithHandle > > > Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:145 > > - ASSERT(m_downloadClient); > > + ASSERT(!m_downloadClient); > > ASSERT(m_resourceHandle); > > This should be !m_resourceHandle, since it's assigned to resourceHandle below Yeah I overlooked it, I thought the ASSERT was checking the function argument Comment on attachment 123735 [details]
Patch
Please land with cgarcia's suggested fix.
Committed r105746: <http://trac.webkit.org/changeset/105746> |