Bug 76915 – [WK2] [GTK] TestDownloads hitting an assertion in Debug builds

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Sergio Villar Senin]

This is the assertion

ASSERTION FAILED: m_downloadClient (DownloadSoup.cpp:135)

[Sergio Villar Senin]

Created attachment 123735 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 123735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123735&action=review

Yeah, my fault, sorry, Patch is correct, except the m_resourceHandle in Download::startWithHandle

> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:145
> -    ASSERT(m_downloadClient);
> +    ASSERT(!m_downloadClient);
>      ASSERT(m_resourceHandle);

This should be !m_resourceHandle, since it's assigned to resourceHandle below

[Sergio Villar Senin]

(In reply to comment #2)
> (From update of attachment 123735 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123735&action=review
> 
> Yeah, my fault, sorry, Patch is correct, except the m_resourceHandle in Download::startWithHandle
> 
> > Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:145
> > -    ASSERT(m_downloadClient);
> > +    ASSERT(!m_downloadClient);
> >      ASSERT(m_resourceHandle);
> 
> This should be !m_resourceHandle, since it's assigned to resourceHandle below

Yeah I overlooked it, I thought the ASSERT was checking the function argument

[Martin Robinson]

Comment on attachment 123735 [details]
Patch

Please land with cgarcia's suggested fix.

[Sergio Villar Senin]

Committed r105746: <http://trac.webkit.org/changeset/105746>