Bug 76909

Summary: Remove unnecessary baseURL member variable from PluginView
Product: WebKit Reporter: Kaustubh Atrawalkar <kaustubh.ra>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, aroben, eric, kaustubh.ra, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Kaustubh Atrawalkar 2012-01-24 06:12:32 PST
With reference to earlier bug - https://bugs.webkit.org/show_bug.cgi?id=62818, There was a fixme added to remove the unnecessary m_baseURL member variable. Adding bug for the same. This will reduce the PluginView object memory footprint. Will upload fix soon.
Comment 1 Kaustubh Atrawalkar 2012-01-24 06:36:24 PST
Created attachment 123724 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-01-24 10:36:11 PST
Comment on attachment 123724 [details]
Patch

Is m_parentFrame ever null?  I don't believe a Frame can ever have a null document, thankfully. :)
Comment 3 Kaustubh Atrawalkar 2012-01-25 04:54:13 PST
(In reply to comment #2)
> (From update of attachment 123724 [details])
> Is m_parentFrame ever null?  I don't believe a Frame can ever have a null document, thankfully. :)

No, m_parentFrame can not be null and so as the document :)
Comment 4 WebKit Review Bot 2012-01-25 09:18:50 PST
Comment on attachment 123724 [details]
Patch

Clearing flags on attachment: 123724

Committed r105883: <http://trac.webkit.org/changeset/105883>
Comment 5 WebKit Review Bot 2012-01-25 09:18:54 PST
All reviewed patches have been landed.  Closing bug.