Bug 76904

Summary: Reduce internal use of CSSStyleDeclaration base class
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77745    
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2012-01-24 04:44:55 PST
Internally WebCore should use the more specific CSSMutableStyleDeclaration and CSSComputedStyleDeclaration types. The CSSStyleDeclaration base should be used in the DOM API functions only. This will make it easier to separate internal style sheet implementation from the DOM in the future.
Attachments
patch (22.03 KB, patch)
2012-01-24 05:04 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-01-24 05:04:34 PST
Created attachment 123716 [details] patch
WebKit Review Bot
Comment 2 2012-01-24 05:07:26 PST
Attachment 123716 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderLayer.cpp:49: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2012-01-24 08:09:28 PST
http://trac.webkit.org/changeset/105739
Note You need to log in before you can comment on or make changes to this bug.