Bug 76899

Summary: [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, pnormand, webkit.review.bot, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch mrobinson: review+

Carlos Garcia Campos
Reported 2012-01-24 02:46:51 PST
They are now private and only provide a way to attach callbacks to the client.
Attachments
Patch (23.11 KB, patch)
2012-01-24 02:52 PST, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-01-24 02:52:51 PST
Created attachment 123708 [details] Patch
WebKit Review Bot
Comment 2 2012-01-24 02:54:19 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2012-01-24 06:48:19 PST
Comment on attachment 123708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123708&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:22 > #include "WebKitWebLoaderClient.h" Please rename this file to WebKitLoaderClient to match the name of the client now.
Carlos Garcia Campos
Comment 4 2012-01-25 00:37:21 PST
Committed r105854: <http://trac.webkit.org/changeset/105854>
Note You need to log in before you can comment on or make changes to this bug.