Bug 76889

Summary: [windows] Convert usage of GetDC to HWndDC Part 3.
Product: WebKit Reporter: David Levin <levin>
Component: PlatformAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 76737    
Bug Blocks: 76303    
Attachments:
Description Flags
Patch
none
Patch none

David Levin
Reported 2012-01-23 17:56:34 PST
The files that needed to use setHWnd (and the other changes in those files as well).
Attachments
Patch (7.24 KB, patch)
2012-01-23 18:02 PST, David Levin 		no flags
DetailsFormatted DiffDiff
Patch (7.22 KB, patch)
2012-01-24 09:06 PST, David Levin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2012-01-23 18:02:45 PST
Created attachment 123683 [details] Patch
David Levin
Comment 2 2012-01-23 18:03:40 PST
Last one!
WebKit Review Bot
Comment 3 2012-01-23 18:06:02 PST
Attachment 123683 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp:812: Use adoptPtr and OwnPtr<HDC> when calling CreateCompatibleDC to avoid potential memory leaks. [runtime/leaky_pattern] [5] Source/WebCore/platform/win/PopupMenuWin.cpp:571: Use adoptPtr and OwnPtr<HDC> when calling CreateCompatibleDC to avoid potential memory leaks. [runtime/leaky_pattern] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Levin
Comment 4 2012-01-24 01:21:03 PST
Comment on attachment 123683 [details] Patch Need to fix the api call.
David Levin
Comment 5 2012-01-24 09:06:30 PST
Created attachment 123746 [details] Patch
WebKit Review Bot
Comment 6 2012-01-24 09:13:45 PST
Attachment 123746 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp:812: Use adoptPtr and OwnPtr<HDC> when calling CreateCompatibleDC to avoid potential memory leaks. [runtime/leaky_pattern] [5] Source/WebCore/platform/win/PopupMenuWin.cpp:571: Use adoptPtr and OwnPtr<HDC> when calling CreateCompatibleDC to avoid potential memory leaks. [runtime/leaky_pattern] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 7 2012-01-24 10:52:06 PST
Comment on attachment 123746 [details] Patch Clearing flags on attachment: 123746 Committed r105756: <http://trac.webkit.org/changeset/105756>
WebKit Review Bot
Comment 8 2012-01-24 10:52:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.