[Qt][WK2] Qt's cross-process AC copies images excessively when updating tiles.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Noam Rosenthal]

Apart from double buffering, update buffers go through several message queues, and get copied in between. This is unnecessary.

[Noam Rosenthal]

Created attachment 123658 [details]
Patch

[Noam Rosenthal]

Created attachment 123660 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 123660 [details]
Patch

Nice!

[Jocelyn Turcotte]

Comment on attachment 123660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123660&action=review

> Source/WebKit2/WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:92
> +    bitmap->swizzleRGB();

It's difficult to follow which format is used where, could you add a comment here saying from which to which you are converting?

[Noam Rosenthal]

Created attachment 123723 [details]
Patch

Added comments as per Jocelyn's request.

[WebKit Review Bot]

Comment on attachment 123723 [details]
Patch

Rejecting attachment 123723 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

NOBODY Kenneth Rohde Christiansen found in /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11335374

[Noam Rosenthal]

Created attachment 123725 [details]
Patch

[WebKit Review Bot]

Comment on attachment 123725 [details]
Patch

Clearing flags on attachment: 123725

Committed r105737: <http://trac.webkit.org/changeset/105737>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.