Bug 76877

Summary: [Qt][WK2] Qt's cross-process AC copies images excessively when updating tiles.
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jturcotte, kenneth, ostap73, webkit.review.bot, zoltan
Priority: P2 Keywords: Performance, Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
kenneth: review+
Patch
webkit.review.bot: commit-queue-
Patch none

Noam Rosenthal
Reported 2012-01-23 16:33:27 PST
Apart from double buffering, update buffers go through several message queues, and get copied in between. This is unnecessary.
Attachments
Patch (17.18 KB, patch)
2012-01-23 16:47 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (16.25 KB, patch)
2012-01-23 16:51 PST, Noam Rosenthal 		kenneth: review+
DetailsFormatted DiffDiff
Patch (16.41 KB, patch)
2012-01-24 06:21 PST, Noam Rosenthal 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (16.40 KB, patch)
2012-01-24 06:45 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-01-23 16:47:39 PST
Created attachment 123658 [details] Patch
Noam Rosenthal
Comment 2 2012-01-23 16:51:08 PST
Created attachment 123660 [details] Patch
Kenneth Rohde Christiansen
Comment 3 2012-01-24 02:01:27 PST
Comment on attachment 123660 [details] Patch Nice!
Jocelyn Turcotte
Comment 4 2012-01-24 03:21:36 PST
Comment on attachment 123660 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123660&action=review > Source/WebKit2/WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:92 > + bitmap->swizzleRGB(); It's difficult to follow which format is used where, could you add a comment here saying from which to which you are converting?
Noam Rosenthal
Comment 5 2012-01-24 06:21:31 PST
Created attachment 123723 [details] Patch Added comments as per Jocelyn's request.
WebKit Review Bot
Comment 6 2012-01-24 06:24:44 PST
Comment on attachment 123723 [details] Patch Rejecting attachment 123723 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 NOBODY Kenneth Rohde Christiansen found in /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11335374
Noam Rosenthal
Comment 7 2012-01-24 06:45:56 PST
Created attachment 123725 [details] Patch
WebKit Review Bot
Comment 8 2012-01-24 07:17:26 PST
Comment on attachment 123725 [details] Patch Clearing flags on attachment: 123725 Committed r105737: <http://trac.webkit.org/changeset/105737>
WebKit Review Bot
Comment 9 2012-01-24 07:17:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.