Bug 76856

Summary: Convert DataTransferItem/DataTransferItemList back into an interface class
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: New BugsAssignee: Daniel Cheng <dcheng>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76598    
Attachments:
Description Flags
Patch
none
Patch none

Description Daniel Cheng 2012-01-23 13:22:51 PST 
Convert DataTransferItem/DataTransferItemList back into an interface class
Comment 1 Daniel Cheng 2012-01-23 13:23:39 PST 
Created attachment 123607 [details]
Patch
Comment 2 Daniel Cheng 2012-01-23 14:29:05 PST 
Created attachment 123621 [details]
Patch
Comment 3 David Levin 2012-01-23 15:28:39 PST 
Comment on attachment 123621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123621&action=review

> Source/WebCore/platform/chromium/DataTransferItemListChromium.h:65
> +    RefPtr<Clipboard> m_owner;

Why not make this a RefPtr<ClipboardChromium> and ditto for the create methods now that they are Chromium specific ?
Comment 4 Daniel Cheng 2012-01-23 15:32:02 PST 
(In reply to comment #3)
> (From update of attachment 123621 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123621&action=review
> 
> > Source/WebCore/platform/chromium/DataTransferItemListChromium.h:65
> > +    RefPtr<Clipboard> m_owner;
> 
> Why not make this a RefPtr<ClipboardChromium> and ditto for the create methods now that they are Chromium specific ?

As discusses, this code will be disappearing shortly anyway.
Comment 5 Daniel Cheng 2012-01-23 15:35:52 PST 
Comment on attachment 123621 [details]
Patch

Clearing flags on attachment: 123621

Committed r105648: <http://trac.webkit.org/changeset/105648>
Comment 6 Daniel Cheng 2012-01-23 15:35:56 PST 
All reviewed patches have been landed.  Closing bug.