Bug 76853

Summary:

[chromium] Clean up old WebSharedWorker::startWorkerContext() method.

Product:

WebKit

Reporter:

Thomas Sepez <tsepez>

Component:

WebKit Misc.

Assignee:

Thomas Sepez <tsepez>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

abarth, fishd, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Thomas Sepez

Reported 2012-01-23 12:43:18 PST

Follow-on task from https://bugs.webkit.org/show_bug.cgi?id=75660 Make the new WebSharedWorker::startWorkerContext() method a pure virtual one [instead of a bridge calling back into the old method], and remove the old method entirely from the webkit side.

Attachments
Patch (4.26 KB, patch) 2012-01-23 13:07 PST, Thomas Sepez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Thomas Sepez

Comment 1 2012-01-23 13:07:41 PST

Created attachment 123606 [details] Patch

Thomas Sepez

Comment 2 2012-01-23 13:11:52 PST

[Manually copying patch over to the chromium side to confirm build is still OK]

Thomas Sepez

Comment 3 2012-01-23 13:27:11 PST

Comment on attachment 123606 [details] Patch Darin, please review. This should be straightforward since I am merely removing code now that the chromium side has caught up and no longer needs this.

WebKit Review Bot

Comment 4 2012-01-23 13:29:17 PST

Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.

WebKit Review Bot

Comment 5 2012-01-23 20:38:44 PST

Comment on attachment 123606 [details] Patch Clearing flags on attachment: 123606 Committed r105687: <http://trac.webkit.org/changeset/105687>

WebKit Review Bot

Comment 6 2012-01-23 20:38:48 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.