Bug 76853 - [chromium] Clean up old WebSharedWorker::startWorkerContext() method.
Summary: [chromium] Clean up old WebSharedWorker::startWorkerContext() method.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Thomas Sepez
Depends on:
Reported: 2012-01-23 12:43 PST by Thomas Sepez
Modified: 2012-01-23 20:38 PST (History)
3 users (show)

See Also:

Patch (4.26 KB, patch)
2012-01-23 13:07 PST, Thomas Sepez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Sepez 2012-01-23 12:43:18 PST
Follow-on task from https://bugs.webkit.org/show_bug.cgi?id=75660

Make the new WebSharedWorker::startWorkerContext() method a pure virtual one [instead of a bridge calling back into the old method], and remove the old method entirely from the webkit side.
Comment 1 Thomas Sepez 2012-01-23 13:07:41 PST
Created attachment 123606 [details]
Comment 2 Thomas Sepez 2012-01-23 13:11:52 PST
[Manually copying patch over to the chromium side to confirm build is still OK]
Comment 3 Thomas Sepez 2012-01-23 13:27:11 PST
Comment on attachment 123606 [details]

Darin,  please review.

This should be straightforward since I am merely removing code now that the chromium side has caught up and no longer needs this.
Comment 4 WebKit Review Bot 2012-01-23 13:29:17 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 5 WebKit Review Bot 2012-01-23 20:38:44 PST
Comment on attachment 123606 [details]

Clearing flags on attachment: 123606

Committed r105687: <http://trac.webkit.org/changeset/105687>
Comment 6 WebKit Review Bot 2012-01-23 20:38:48 PST
All reviewed patches have been landed.  Closing bug.