Bug 7685
| Summary: | Focus ring color should change to match graphite when system theme is graphite | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | mitz |
| Component: | Layout and Rendering | Assignee: | Darin Adler <darin> |
| Status: | VERIFIED FIXED | ||
| Severity: | Normal | ||
| Priority: | P1 | ||
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
mitz
When the Graphite appearance is selected in System Preferences, contenteditable elements' focus rings should be graphite by default rather than blue.
Currently the default focus ring color comes from html4.css:
:focus {
outline: auto 3px #1f5ccf
}
This rule should change dynamically to match the selection in System Preferences.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
John Sullivan
Supporting Graphite well has not been a high priority lately, but I agree completely that this change would be a correct one. The system's focus ring color does change to a gray color when Graphite has been selected.
Dave Hyatt
Just need a special keyword for the color, e.g., -khtml-focus-ring-color
Dave Hyatt
Just need a special keyword for the color, e.g., -khtml-focus-ring-color
Adele Peterson
Bumping to P1 since this causes a text field regression
Darin Adler
The patch I am about to attach to bug 8123 fixes this bug as well.
mitz
Verified in r13675 nightly.