Bug 76846

Summary: [Refactoring] Make finish() of CodeGeneratorJS.pm empty
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, ossy, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76836    
Attachments:
Description Flags
Patch
none
proposed warning fix none

Description Kentaro Hara 2012-01-23 11:21:34 PST 
This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836).

As a refactoring, we are planning to remove finish() from all CodeGenerators. In this bug, we make finish() of CodeGeneratorJS.pm empty.
Comment 1 Kentaro Hara 2012-01-23 11:36:03 PST 
Created attachment 123585 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-23 20:00:15 PST 
Comment on attachment 123585 [details]
Patch

Clearing flags on attachment: 123585

Committed r105683: <http://trac.webkit.org/changeset/105683>
Comment 3 WebKit Review Bot 2012-01-23 20:00:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2012-01-23 23:55:57 PST 
Comment on attachment 123585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123585&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3251
> +    my @includes = ();

Here is the first declaration.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3290
> +    my @includes = ();

This change caused the following warning:
"my" variable @includes masks earlier declaration in same scope at /home/oszi/WebKit/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm line 3290.
Comment 5 Csaba Osztrogonác 2012-01-24 00:04:18 PST 
Reopening to attach new patch.
Comment 6 Csaba Osztrogonác 2012-01-24 00:04:23 PST 
Created attachment 123703 [details]
proposed warning fix
Comment 7 Csaba Osztrogonác 2012-01-24 05:58:39 PST 
Comment on attachment 123703 [details]
proposed warning fix

Landed in http://trac.webkit.org/changeset/105734
Comment 8 Simon Fraser (smfr) 2012-01-24 15:14:26 PST 
When I do incremental builds today, I see all IDL files being processed every time. This didn't used to happen.
Comment 9 Kentaro Hara 2012-01-24 16:59:23 PST 
(In reply to comment #8)
> When I do incremental builds today, I see all IDL files being processed every time. This didn't used to happen.

smfr: I was able to reproduce it. I'll fix it.
Comment 10 Kentaro Hara 2012-01-24 18:16:41 PST 
(In reply to comment #8)
> When I do incremental builds today, I see all IDL files being processed every time. This didn't used to happen.

smfr: Fixed it in bug 76970.