Bug 76843

Summary: Web Inspector: show memory counter graphs in timeline panel
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review+
Screenshot with the patch applied
none
Patch for landing none

Description Yury Semikhatsky 2012-01-23 11:14:43 PST 
This is an experimental feature which allows to view dynamics of various DOM counters including total node count, number of DOM groups and number of event listeners in the document.
Comment 1 Yury Semikhatsky 2012-01-23 11:40:48 PST 
Created attachment 123589 [details]
Patch
Comment 2 Pavel Feldman 2012-01-25 00:55:04 PST 
Is there a screenshot?
Comment 3 Yury Semikhatsky 2012-01-25 03:46:57 PST 
Created attachment 123916 [details]
Screenshot with the patch applied
Comment 4 Pavel Feldman 2012-01-25 04:00:04 PST 
Comment on attachment 123589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123589&action=review

> Source/WebCore/inspector/Inspector.json:1897
> +                "name": "setDomCountersEnabled",

setIncludeMemoryDetails ?

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:412
> +        m_recordStack.last().record->setArray("memory", domGroups.release());

This field seems to conflict with the heap info we are sending.

> Source/WebCore/inspector/front-end/TimelinePanel.js:155
> +WebInspector.MemoryStatistics.prototype = {

Could you extract this into a separate file?
Comment 5 Yury Semikhatsky 2012-01-25 06:40:13 PST 
Comment on attachment 123589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123589&action=review

>> Source/WebCore/inspector/Inspector.json:1897
>> +                "name": "setDomCountersEnabled",
> 
> setIncludeMemoryDetails ?

Done.

>> Source/WebCore/inspector/InspectorTimelineAgent.cpp:412
>> +        m_recordStack.last().record->setArray("memory", domGroups.release());
> 
> This field seems to conflict with the heap info we are sending.

Renamed to domGroups for now.

>> Source/WebCore/inspector/front-end/TimelinePanel.js:155
>> +WebInspector.MemoryStatistics.prototype = {
> 
> Could you extract this into a separate file?

Done.
Comment 6 Yury Semikhatsky 2012-01-25 06:40:52 PST 
Created attachment 123930 [details]
Patch for landing
Comment 7 Yury Semikhatsky 2012-01-25 07:10:59 PST 
Committed r105877: <http://trac.webkit.org/changeset/105877>