| Summary: | [Refactoring] Remove finish() from CodeGeneratorV8.pm | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
| Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, darin, japhet, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 76836 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kentaro Hara
2012-01-23 10:52:10 PST
Created attachment 123576 [details]
Patch
Comment on attachment 123576 [details] Patch Rejecting attachment 123576 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ion 55 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 106. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2302. Full output: http://queues.webkit.org/results/11333241 Created attachment 123697 [details]
rebased patch for review
adam: Sorry, would you please r+ again? I forgot to add --no-review option. Comment on attachment 123697 [details] rebased patch for review Clearing flags on attachment: 123697 Committed r105714: <http://trac.webkit.org/changeset/105714> All reviewed patches have been landed. Closing bug. |