Bug 76832 – [Qt] Build fix when using force_static_libs_as_shared

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Yael]

When building a debug build on Linux with 32 bit machines, we must use force_static_libs_as_shared or we cannot link.
When WebKit2 and WebCore are built as a shared library, we must add QT+=widgets for them to link.

[Yael]

Created attachment 123560 [details]
Patch.

[Simon Hausmann]

Comment on attachment 123560 [details]
Patch.

I think the dependency is correct, but I don't think that it should be guarded with force_static_libs_as_shared. It is a _real_ dependency and it should IMHO be expressed as such, i.e. without the force_static_libs_as_shared scope.

[Yael]

Created attachment 123770 [details]
Patch.

Removed the flag, as suggested by Simon.

[WebKit Review Bot]

Comment on attachment 123770 [details]
Patch.

Clearing flags on attachment: 123770

Committed r105881: <http://trac.webkit.org/changeset/105881>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Yael]

This got broken again by r108328

[Andras Becsi]

The build with --qmakearg="CONFIG+=force_static_libs_as_shared" works for me.
What build options do you use?

You need a clean build after this change, since the build system has some problems with changing module dependency settings in project files.

[Andras Becsi]

(In reply to comment #6)
> This got broken again by r108328

Looks like the option actually broke because of r108359.
The inclusion order resulted in some defines being undeffed by the new header.

The fixed patch was landed in http://trac.webkit.org/changeset/108483.

[Yael]

(In reply to comment #8)

> The fixed patch was landed in http://trac.webkit.org/changeset/108483.
Thanks for fixing it :)

[Yael]

(In reply to comment #8)
> (In reply to comment #6)
> > This got broken again by r108328
> 
> Looks like the option actually broke because of r108359.
> The inclusion order resulted in some defines being undeffed by the new header.
> 
> The fixed patch was landed in http://trac.webkit.org/changeset/108483.

This is still broken. WebKit2 is still using QWidgets such as QFileDialog etc.
When building with force_static_libs_as_shared, WebKit2 is a self contained dll and it needs to have QT+=widgets.

This problem has nothing to do with  http://trac.webkit.org/changeset/108483 , and is indeed regression from 108328, which removed QT+=widgets .

Clean build with default flags, not specifying any flags on the command line is currently failing. (with latest Qt5).

[Simon Hausmann]

(In reply to comment #10)
> (In reply to comment #8)
> > (In reply to comment #6)
> > > This got broken again by r108328
> > 
> > Looks like the option actually broke because of r108359.
> > The inclusion order resulted in some defines being undeffed by the new header.
> > 
> > The fixed patch was landed in http://trac.webkit.org/changeset/108483.
> 
> This is still broken. WebKit2 is still using QWidgets such as QFileDialog etc.
> When building with force_static_libs_as_shared, WebKit2 is a self contained dll and it needs to have QT+=widgets.
> 
> This problem has nothing to do with  http://trac.webkit.org/changeset/108483 , and is indeed regression from 108328, which removed QT+=widgets .
> 
> Clean build with default flags, not specifying any flags on the command line is currently failing. (with latest Qt5).

Yael, you're right. I've filed bug #79458 for this.