Bug 76803

Summary:

[V8] Add Uint8ClampedArray support

Product:

WebKit

Reporter:

Kenichi Ishibashi <bashi>

Component:

Platform

Assignee:

Kenichi Ishibashi <bashi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cmarcelo, fpizlo, japhet, kbr, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

73011

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Kenichi Ishibashi

Reported 2012-01-22 19:09:31 PST

JSC supports Uint8ClampedArray as of r105217. It would be better to support it on V8.

Attachments
Patch (27.37 KB, patch) 2012-01-22 21:00 PST, Kenichi Ishibashi	no flags	Details Formatted Diff Diff
Patch for landing (14.66 KB, patch) 2012-01-23 15:54 PST, Kenichi Ishibashi	no flags	Details Formatted Diff Diff
Patch for landing (30.00 KB, patch) 2012-01-23 17:37 PST, Kenichi Ishibashi	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kenichi Ishibashi

Comment 1 2012-01-22 21:00:10 PST

Created attachment 123516 [details] Patch

Kenneth Russell

Comment 2 2012-01-23 11:13:25 PST

Comment on attachment 123516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123516&action=review Thanks very much for filing and fixing this. Marking r+, but please see the above comments (in particular about getting rid of the separate Chromium baseline for array-unit-tests.html) and watch the EWS bots before committing. > Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:16 > + * this software without specific prior written permission. Wrong version of copyright notice; should be the two-clause license from Source/WebKit/LICENSE (with copyright Google, as you have here). > LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt:-1 > -CONSOLE MESSAGE: line 222: Uncaught ReferenceError: Uint8ClampedArray is not defined Can you just remove this expectation at this point? I don't think it should be needed any more.

Kenichi Ishibashi

Comment 3 2012-01-23 15:54:57 PST

Created attachment 123643 [details] Patch for landing

Kenichi Ishibashi

Comment 4 2012-01-23 15:56:20 PST

Comment on attachment 123516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123516&action=review Thank you for review! >> Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:16 >> + * this software without specific prior written permission. > > Wrong version of copyright notice; should be the two-clause license from Source/WebKit/LICENSE (with copyright Google, as you have here). Done. >> LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt:-1 >> -CONSOLE MESSAGE: line 222: Uncaught ReferenceError: Uint8ClampedArray is not defined > > Can you just remove this expectation at this point? I don't think it should be needed any more. Done.

Kenneth Russell

Comment 5 2012-01-23 17:10:45 PST

I don't see the deletion of LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt in the above patch.

Kenichi Ishibashi

Comment 6 2012-01-23 17:37:51 PST

Created attachment 123672 [details] Patch for landing

Kenichi Ishibashi

Comment 7 2012-01-23 17:39:53 PST

(In reply to comment #5) > I don't see the deletion of LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt in the above patch. Revised the patch. Thank you for pointing this out.

WebKit Review Bot

Comment 8 2012-01-24 00:56:29 PST

Comment on attachment 123672 [details] Patch for landing Clearing flags on attachment: 123672 Committed r105705: <http://trac.webkit.org/changeset/105705>

WebKit Review Bot

Comment 9 2012-01-24 00:56:35 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.