Summary: | [V8] Add Uint8ClampedArray support | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenichi Ishibashi <bashi> | ||||||||
Component: | Platform | Assignee: | Kenichi Ishibashi <bashi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, cmarcelo, fpizlo, japhet, kbr, ojan, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 73011 | ||||||||||
Attachments: |
|
Description
Kenichi Ishibashi
2012-01-22 19:09:31 PST
Created attachment 123516 [details]
Patch
Comment on attachment 123516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123516&action=review Thanks very much for filing and fixing this. Marking r+, but please see the above comments (in particular about getting rid of the separate Chromium baseline for array-unit-tests.html) and watch the EWS bots before committing. > Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:16 > + * this software without specific prior written permission. Wrong version of copyright notice; should be the two-clause license from Source/WebKit/LICENSE (with copyright Google, as you have here). > LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt:-1 > -CONSOLE MESSAGE: line 222: Uncaught ReferenceError: Uint8ClampedArray is not defined Can you just remove this expectation at this point? I don't think it should be needed any more. Created attachment 123643 [details]
Patch for landing
Comment on attachment 123516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123516&action=review Thank you for review! >> Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:16 >> + * this software without specific prior written permission. > > Wrong version of copyright notice; should be the two-clause license from Source/WebKit/LICENSE (with copyright Google, as you have here). Done. >> LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt:-1 >> -CONSOLE MESSAGE: line 222: Uncaught ReferenceError: Uint8ClampedArray is not defined > > Can you just remove this expectation at this point? I don't think it should be needed any more. Done. I don't see the deletion of LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt in the above patch. Created attachment 123672 [details]
Patch for landing
(In reply to comment #5) > I don't see the deletion of LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt in the above patch. Revised the patch. Thank you for pointing this out. Comment on attachment 123672 [details] Patch for landing Clearing flags on attachment: 123672 Committed r105705: <http://trac.webkit.org/changeset/105705> All reviewed patches have been landed. Closing bug. |