Summary: | [BlackBerry]Use extension for a mimetype as the suggested extension if the url file doesn't have an extension. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Charles Wei <charles.wei> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Other | ||||||
Attachments: |
|
Description
Charles Wei
2012-01-21 00:31:35 PST
Created attachment 125606 [details]
Patch
Comment on attachment 125606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125606&action=review > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:614 > + // fill it in from the url and sniffed mime type;Skip this for data and about URLs, the Skip section seems untidy. Needs a space and no need for capital S. > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625 > + suggestedFilename = String("Untitled") + "." + mimeExtension; This could be done differently: suggestedFilename = String("Untitled"); if (!mimeExtension.isEmpty()) // No extension found for the mimeType. suggestedFilename = "." + mimeExtension; > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:630 > + suggestedFilename = urlFilename; Ditto. Comment on attachment 125606 [details] Patch Clearing flags on attachment: 125606 Committed r106802: <http://trac.webkit.org/changeset/106802> All reviewed patches have been landed. Closing bug. |