Bug 76779 – [BlackBerry]Use extension for a mimetype as the suggested extension if the url file doesn't have an extension.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Charles Wei]

If the url file doesn't have an extension,  like http://domain/noextension, we should try to append the extension of the mime type to the suggested file.  like if it happen to be a text file indicated by the MIME,  we should suggest the file name as : noextension.txt

[Charles Wei]

Created attachment 125606 [details]
Patch

[Rob Buis]

Comment on attachment 125606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125606&action=review

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:614
> +    // fill it in from the url and sniffed mime type;Skip this for data and about URLs,

the Skip section seems untidy. Needs a space and no need for capital S.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625
> +                    suggestedFilename = String("Untitled") + "." + mimeExtension;

This could be done differently:
suggestedFilename = String("Untitled");
if (!mimeExtension.isEmpty()) // No extension found for the mimeType.
    suggestedFilename = "." + mimeExtension;

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:630
> +                   suggestedFilename = urlFilename;

Ditto.

[WebKit Review Bot]

Comment on attachment 125606 [details]
Patch

Clearing flags on attachment: 125606

Committed r106802: <http://trac.webkit.org/changeset/106802>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.