|Summary:||[BlackBerry]Use extension for a mimetype as the suggested extension if the url file doesn't have an extension.|
|Product:||WebKit||Reporter:||Charles Wei <charles.wei>|
|Component:||WebCore Misc.||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||rwlbuis, staikos, tonikitoo, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Charles Wei 2012-01-21 00:31:35 PST
If the url file doesn't have an extension, like http://domain/noextension, we should try to append the extension of the mime type to the suggested file. like if it happen to be a text file indicated by the MIME, we should suggest the file name as : noextension.txt
Comment 2 Rob Buis 2012-02-06 05:45:44 PST
Comment on attachment 125606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125606&action=review > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:614 > + // fill it in from the url and sniffed mime type;Skip this for data and about URLs, the Skip section seems untidy. Needs a space and no need for capital S. > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625 > + suggestedFilename = String("Untitled") + "." + mimeExtension; This could be done differently: suggestedFilename = String("Untitled"); if (!mimeExtension.isEmpty()) // No extension found for the mimeType. suggestedFilename = "." + mimeExtension; > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:630 > + suggestedFilename = urlFilename; Ditto.
Comment 3 WebKit Review Bot 2012-02-06 05:55:28 PST
Comment on attachment 125606 [details] Patch Clearing flags on attachment: 125606 Committed r106802: <http://trac.webkit.org/changeset/106802>
Comment 4 WebKit Review Bot 2012-02-06 05:55:32 PST
All reviewed patches have been landed. Closing bug.