Bug 76771

Summary: PopupMenuClient::multiple() should be const
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebCore Misc.Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, kling, tkent, webkit.review.bot
Priority: P2 Keywords: EasyFix
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2012-01-20 22:37:20 PST
It is an accessor, no reason to have it modify the RenderObject.
Attachments
Patch (2.75 KB, patch)
2012-01-20 22:43 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-01-20 22:43:45 PST
Created attachment 123432 [details] Patch
Kent Tamura
Comment 2 2012-01-20 22:49:07 PST
Comment on attachment 123432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123432&action=review > Source/WebCore/rendering/RenderMenuList.h:110 > + virtual bool multiple() const; I recommend adding OVERRIDE to this line.
Benjamin Poulain
Comment 3 2012-01-20 23:01:04 PST
> I recommend adding OVERRIDE to this line. Yeah, I considered that. But I think I should modify the whole interface on one patch instead of a single method.
Kent Tamura
Comment 4 2012-01-20 23:06:26 PST
Comment on attachment 123432 [details] Patch ok
WebKit Review Bot
Comment 5 2012-01-21 00:17:43 PST
Comment on attachment 123432 [details] Patch Clearing flags on attachment: 123432 Committed r105570: <http://trac.webkit.org/changeset/105570>
WebKit Review Bot
Comment 6 2012-01-21 00:17:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.