Bug 76754

Summary: Fine tune Web Intents Chromium API
Product: WebKit Reporter: Greg Billock <gbillock>
Component: New BugsAssignee: Greg Billock <gbillock>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75123    
Attachments:
Description Flags
Patch
none
Patch none

Greg Billock
Reported 2012-01-20 16:30:23 PST
Fine tune Web Intents Chromium API
Attachments
Patch (3.39 KB, patch)
2012-01-20 16:31 PST, Greg Billock 		no flags
DetailsFormatted DiffDiff
Patch (3.44 KB, patch)
2012-01-23 10:31 PST, Greg Billock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Greg Billock
Comment 1 2012-01-20 16:31:53 PST
Created attachment 123406 [details] Patch
Greg Billock
Comment 2 2012-01-20 16:34:45 PST
Removes identifier() method from Web Intent, adds webkit constructor for WebIntentServiceInfo. This shouldn't be merged until after the Chromium code using the removed API lands (http://codereview.chromium.org/9186021/)
WebKit Review Bot
Comment 3 2012-01-20 16:36:28 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 4 2012-01-20 20:45:27 PST
Comment on attachment 123406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123406&action=review > Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36 > +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action, nit: please list functions in the .cpp file in the same order as they appear in the .h file.
Greg Billock
Comment 5 2012-01-23 10:30:16 PST
Comment on attachment 123406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123406&action=review >> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36 >> +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action, > > nit: please list functions in the .cpp file in the same order as they appear in the .h file. Done.
Greg Billock
Comment 6 2012-01-23 10:31:22 PST
Created attachment 123573 [details] Patch
WebKit Review Bot
Comment 7 2012-01-23 19:20:24 PST
Comment on attachment 123573 [details] Patch Clearing flags on attachment: 123573 Committed r105681: <http://trac.webkit.org/changeset/105681>
WebKit Review Bot
Comment 8 2012-01-23 19:20:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.