Bug 76754

Summary: Fine tune Web Intents Chromium API
Product: WebKit Reporter: Greg Billock <gbillock>
Component: New BugsAssignee: Greg Billock <gbillock>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75123    
Attachments:
Description Flags
Patch
none
Patch none

Description Greg Billock 2012-01-20 16:30:23 PST 
Fine tune Web Intents Chromium API
Comment 1 Greg Billock 2012-01-20 16:31:53 PST 
Created attachment 123406 [details]
Patch
Comment 2 Greg Billock 2012-01-20 16:34:45 PST 
Removes identifier() method from Web Intent, adds webkit constructor for WebIntentServiceInfo.

This shouldn't be merged until after the Chromium code using the removed API lands (http://codereview.chromium.org/9186021/)
Comment 3 WebKit Review Bot 2012-01-20 16:36:28 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 Darin Fisher (:fishd, Google) 2012-01-20 20:45:27 PST 
Comment on attachment 123406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123406&action=review

> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36
> +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action,

nit: please list functions in the .cpp file in the same order as they appear in the .h file.
Comment 5 Greg Billock 2012-01-23 10:30:16 PST 
Comment on attachment 123406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123406&action=review

>> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36
>> +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action,
> 
> nit: please list functions in the .cpp file in the same order as they appear in the .h file.

Done.
Comment 6 Greg Billock 2012-01-23 10:31:22 PST 
Created attachment 123573 [details]
Patch
Comment 7 WebKit Review Bot 2012-01-23 19:20:24 PST 
Comment on attachment 123573 [details]
Patch

Clearing flags on attachment: 123573

Committed r105681: <http://trac.webkit.org/changeset/105681>
Comment 8 WebKit Review Bot 2012-01-23 19:20:29 PST 
All reviewed patches have been landed.  Closing bug.