Bug 76748

Summary: run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, rniwa, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Ojan Vafai
Reported 2012-01-20 15:16:20 PST
run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
Attachments
Patch (1.86 KB, patch)
2012-01-20 15:17 PST, Ojan Vafai 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-01-20 15:17:28 PST
Created attachment 123391 [details] Patch
Ryosuke Niwa
Comment 2 2012-01-20 15:28:39 PST
That's why it was so slow!
Dirk Pranke
Comment 3 2012-01-20 15:42:54 PST
Comment on attachment 123391 [details] Patch Yup, I just noticed this as well :( See also bug 76749, which we might want to land instead of this.
Dirk Pranke
Comment 4 2012-01-20 15:44:40 PST
That said, given that the second time you're collecting tests the filesystem is largely in cache, I wonder how much slower that is now? I.e., what is the total time for collecting twice or once?
Ojan Vafai
Comment 5 2012-01-20 15:47:15 PST
Committed r105551: <http://trac.webkit.org/changeset/105551>
Tony Chang
Comment 6 2012-01-20 22:56:13 PST
Can we add a test to prevent this from regressing (again?)? Might be a bit tricky.
Note You need to log in before you can comment on or make changes to this bug.