Bug 76705

Summary: Web Inspector: IndexedDBModel should keep track of requests sent to the backend.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 75386    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch pfeldman: review+

Description Vsevolod Vlasov 2012-01-20 08:01:26 PST 
IndexedDBModel should keep track of requests sent to the backend.
Comment 1 Vsevolod Vlasov 2012-01-20 08:04:21 PST 
Otherwise after we send a request for a particular frame we can get a response when this frame was already detached/navigated.
Comment 2 Vsevolod Vlasov 2012-01-20 08:35:24 PST 
Created attachment 123326 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-01-20 08:58:29 PST 
Created attachment 123333 [details]
Patch
Comment 4 Pavel Feldman 2012-01-23 01:08:00 PST 
Comment on attachment 123333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123333&action=review

> Source/WebCore/inspector/front-end/IndexedDBModel.js:255
>  WebInspector.IndexedDBDispatcher.prototype = {

We try to keep the logic either in the dispather or in the model. In your case, model is preferred. I'd suggest to make dispatcher a pure delegate.
Comment 5 Vsevolod Vlasov 2012-01-23 06:30:23 PST 
Created attachment 123548 [details]
Patch
Comment 6 Vsevolod Vlasov 2012-01-23 06:54:05 PST 
Created attachment 123554 [details]
Patch
Comment 7 Pavel Feldman 2012-01-23 06:58:28 PST 
Comment on attachment 123554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123554&action=review

> Source/WebCore/inspector/front-end/IndexedDBModel.js:37
> +    this._indexedDBAgent = new WebInspector.IndexedDBAgentWrapper;

We use () upon constructions.

> Source/WebCore/inspector/front-end/IndexedDBModel.js:307
> +WebInspector.IndexedDBAgentWrapper.DatabasesForFrameRequest = function(frameId, callback)

IndexedDBRequestManager?
Comment 8 Vsevolod Vlasov 2012-01-23 07:17:24 PST 
Committed r105621: <http://trac.webkit.org/changeset/105621>