Bug 76705

Summary: Web Inspector: IndexedDBModel should keep track of requests sent to the backend.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 75386    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-01-20 08:01:26 PST
IndexedDBModel should keep track of requests sent to the backend.
Attachments
Patch (13.92 KB, patch)
2012-01-20 08:35 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (13.97 KB, patch)
2012-01-20 08:58 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (15.38 KB, patch)
2012-01-23 06:30 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (15.39 KB, patch)
2012-01-23 06:54 PST, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-01-20 08:04:21 PST
Otherwise after we send a request for a particular frame we can get a response when this frame was already detached/navigated.
Vsevolod Vlasov
Comment 2 2012-01-20 08:35:24 PST
Created attachment 123326 [details] Patch
Vsevolod Vlasov
Comment 3 2012-01-20 08:58:29 PST
Created attachment 123333 [details] Patch
Pavel Feldman
Comment 4 2012-01-23 01:08:00 PST
Comment on attachment 123333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123333&action=review > Source/WebCore/inspector/front-end/IndexedDBModel.js:255 > WebInspector.IndexedDBDispatcher.prototype = { We try to keep the logic either in the dispather or in the model. In your case, model is preferred. I'd suggest to make dispatcher a pure delegate.
Vsevolod Vlasov
Comment 5 2012-01-23 06:30:23 PST
Created attachment 123548 [details] Patch
Vsevolod Vlasov
Comment 6 2012-01-23 06:54:05 PST
Created attachment 123554 [details] Patch
Pavel Feldman
Comment 7 2012-01-23 06:58:28 PST
Comment on attachment 123554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123554&action=review > Source/WebCore/inspector/front-end/IndexedDBModel.js:37 > + this._indexedDBAgent = new WebInspector.IndexedDBAgentWrapper; We use () upon constructions. > Source/WebCore/inspector/front-end/IndexedDBModel.js:307 > +WebInspector.IndexedDBAgentWrapper.DatabasesForFrameRequest = function(frameId, callback) IndexedDBRequestManager?
Vsevolod Vlasov
Comment 8 2012-01-23 07:17:24 PST
Committed r105621: <http://trac.webkit.org/changeset/105621>
Note You need to log in before you can comment on or make changes to this bug.