Bug 76704

Summary: Remove unneccesary canExecuteScripts check from v8 bindings, and correctly indeicate when we're about to execute a script
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

jochen
Reported 2012-01-20 05:55:45 PST
Remove unneccesary canExecuteScripts check from v8 bindings, and correctly indeicate when we're about to execute a script
Attachments
Patch (5.75 KB, patch)
2012-01-20 05:56 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (7.81 KB, patch)
2012-02-02 17:03 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (7.73 KB, patch)
2012-02-03 06:16 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-01-20 05:56:08 PST
Created attachment 123299 [details] Patch
jochen
Comment 2 2012-01-20 05:56:23 PST
still WIP
WebKit Review Bot
Comment 3 2012-01-20 09:26:40 PST
Comment on attachment 123299 [details] Patch Attachment 123299 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11312135 New failing tests: editing/pasteboard/drag-image-in-about-blank-frame.html
jochen
Comment 4 2012-02-02 17:03:33 PST
Created attachment 125212 [details] Patch
WebKit Review Bot
Comment 5 2012-02-02 17:54:28 PST
Comment on attachment 125212 [details] Patch Attachment 125212 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11420043 New failing tests: editing/pasteboard/drag-image-in-about-blank-frame.html
Adam Barth
Comment 6 2012-02-03 00:45:14 PST
Comment on attachment 125212 [details] Patch This seems like a good patch. What's the deal with the failing test?
jochen
Comment 7 2012-02-03 06:16:48 PST
Created attachment 125315 [details] Patch
jochen
Comment 8 2012-02-03 06:17:46 PST
(In reply to comment #6) > (From update of attachment 125212 [details]) > This seems like a good patch. What's the deal with the failing test? seems like the check in V8DOMWrapper.cpp was there for a reason.
WebKit Review Bot
Comment 9 2012-02-03 11:32:50 PST
Comment on attachment 125315 [details] Patch Clearing flags on attachment: 125315 Committed r106680: <http://trac.webkit.org/changeset/106680>
WebKit Review Bot
Comment 10 2012-02-03 11:32:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.