| Summary: | Remove unneccesary canExecuteScripts check from v8 bindings, and correctly indeicate when we're about to execute a script | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||||
| Component: | New Bugs | Assignee: | jochen | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, japhet, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
jochen
2012-01-20 05:55:45 PST
Created attachment 123299 [details]
Patch
still WIP Comment on attachment 123299 [details] Patch Attachment 123299 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11312135 New failing tests: editing/pasteboard/drag-image-in-about-blank-frame.html Created attachment 125212 [details]
Patch
Comment on attachment 125212 [details] Patch Attachment 125212 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11420043 New failing tests: editing/pasteboard/drag-image-in-about-blank-frame.html Comment on attachment 125212 [details]
Patch
This seems like a good patch. What's the deal with the failing test?
Created attachment 125315 [details]
Patch
(In reply to comment #6) > (From update of attachment 125212 [details]) > This seems like a good patch. What's the deal with the failing test? seems like the check in V8DOMWrapper.cpp was there for a reason. Comment on attachment 125315 [details] Patch Clearing flags on attachment: 125315 Committed r106680: <http://trac.webkit.org/changeset/106680> All reviewed patches have been landed. Closing bug. |