Bug 76691

Summary: [GTK] Allow extra jhbuild modulesets
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch gustavo: review+

Philippe Normand
Reported 2012-01-20 02:36:20 PST
It'd be nice if we could add new modulesets and modules easily using env variables. My main use-case is to include my gst-0.11 moduleset :=)
Attachments
Patch (1.77 KB, patch)
2012-01-20 02:40 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (1.87 KB, patch)
2012-01-20 03:27 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2012-01-20 04:32 PST, Philippe Normand 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-01-20 02:40:55 PST
Created attachment 123277 [details] Patch
Gustavo Noronha (kov)
Comment 2 2012-01-20 03:16:39 PST
Comment on attachment 123277 [details] Patch Attachment 123277 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11297056
Philippe Normand
Comment 3 2012-01-20 03:27:16 PST
Created attachment 123279 [details] Patch
Gustavo Noronha (kov)
Comment 4 2012-01-20 04:19:50 PST
Comment on attachment 123279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123279&action=review This is a great idea IMO! I'm just wondering whether we should use some kind of namespace protection for our env variables. Maybe make them WebKitExtraModules (or WEBKIT_EXTRA_MODULES), etc. What say you? > Tools/gtk/jhbuildrc:26 > +__module_file_uri = 'file://' + os.path.join(__gtk_tools_directory, 'jhbuild.modules') s/module/moduleset/ for consistency would be good
Philippe Normand
Comment 5 2012-01-20 04:29:41 PST
(In reply to comment #4) > (From update of attachment 123279 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123279&action=review > > This is a great idea IMO! I'm just wondering whether we should use some kind of namespace protection for our env variables. Maybe make them WebKitExtraModules (or WEBKIT_EXTRA_MODULES), etc. What say you? > I say good idea indeed :) > > Tools/gtk/jhbuildrc:26 > > +__module_file_uri = 'file://' + os.path.join(__gtk_tools_directory, 'jhbuild.modules') > > s/module/moduleset/ for consistency would be good Yup! Will send a new patch!
Philippe Normand
Comment 6 2012-01-20 04:32:07 PST
Created attachment 123291 [details] Patch
Gustavo Noronha (kov)
Comment 7 2012-01-20 07:23:17 PST
Comment on attachment 123291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123291&action=review > Tools/ChangeLog:11 > + * gtk/jhbuildrc: Extra modulesets and modules can be added in > + JHBuild using the EXTRA_MODULESETS and EXTRA_MODULES env variables > + respectively. Use comma-separated values. Example: > + EXTRA_MODULES=file:///path/to/module.set,file:///other/path. LIES =) the variables changed names
Philippe Normand
Comment 8 2012-01-20 08:50:06 PST
Committed r105519: <http://trac.webkit.org/changeset/105519>
Note You need to log in before you can comment on or make changes to this bug.